Contrib.social

Use xxHash instead of SHA-256 when security is not a concern

Open on Drupal.org →
Created on 18 April 2024, 7 months ago
Updated 23 July 2024, 4 months ago

Problem/Motivation

@Catch pointed out in core review https://git.drupalcode.org/project/drupal/-/merge_requests/3608#note_297724

\Drupal\package_manager\Validator\LockFileValidator::getHash could use xxHash algorithms https://php.watch/versions/8.1/xxHash

Probably \Drupal\package_manager\ComposerInspector::invalidateCacheIfNeeded also

Steps to reproduce

Proposed resolution

Use xxhash algorithms for speed. In the cases we will use it for in this issue it is simply to detect if a file, either composer.json or composer.lock has changed.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

3.1

Component

Code

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @tedbow
  • Merge request !1060Resolve #3441923 "Use xxhash" → (Merged) created by tedbow
  • Status changed to Needs review 7 months ago
  • Comment 7 months ago →
    🇺🇸United States tedbow Ithaca, NY, USA
  • Comment 7 months ago →
    🇺🇸United States tedbow Ithaca, NY, USA
  • Status changed to Needs work 7 months ago
  • Comment 7 months ago →
    🇺🇸United States phenaproxima Massachusetts

    I'm happy with this, but it looks like it needs a merge/rebase against the target branch.

  • Status changed to RTBC 7 months ago
  • Comment 7 months ago →
    🇺🇸United States tedbow Ithaca, NY, USA

    Going to self RTBC based of #5, I merged 3.1.x

  • Status changed to Needs work 5 months ago
  • Comment 5 months ago →
    🇬🇧United Kingdom catch

    Looks good but conflicts again.

  • Status changed to RTBC 5 months ago
  • Comment 5 months ago →
    🇺🇸United States phenaproxima Massachusetts

    Fixed the conflict, will merge when green.

  • Comment 5 months ago →
    🇺🇸United States phenaproxima Massachusetts
  • Pipeline finished with Failed
    5 months ago
    Total: 1047s
    #219207
  • Pipeline finished with Failed
    5 months ago
    Total: 1209s
    #219222
  • Pipeline finished with Failed
    5 months ago
    Total: 1459s
    #219236
  • Pipeline finished with Failed
    5 months ago
    Total: 1460s
    #219261
  • Pipeline finished with Failed
    5 months ago
    #219757
  • Pipeline finished with Failed
    5 months ago
    #219758
  • Pipeline finished with Canceled
    5 months ago
    Total: 232s
    #219759
  • Pipeline finished with Failed
    5 months ago
    Total: 1201s
    #219764
  • Pipeline finished with Failed
    5 months ago
    Total: 980s
    #219810
  • Pipeline finished with Failed
    5 months ago
    Total: 627s
    #219824
  • Pipeline finished with Failed
    5 months ago
    Total: 689s
    #219832
  • Pipeline finished with Success
    5 months ago
    #219840
  • Pipeline finished with Skipped
    5 months ago
    #219852
  • Comment 5 months ago →
    System Message
  • Status changed to Fixed 5 months ago
  • Comment 5 months ago →
    🇺🇸United States phenaproxima Massachusetts
  • Comment 4 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024