Status check error and warning summary messages do not make sense on the updater forms

For instance
On the update continue form if there are warnings

Your site does not pass some readiness checks for automatic updates. Depending on the nature of the failures, it might affect the eligibility for automatic updates

What does "eligibility" mean in this context? What is this suppose to mean the use at this point.

this will be covered in 🐛 Staged database updates messages is unclear Active

@yash.rode so do you think this issue duplicate of 🐛 Staged database updates messages is unclear Active ? If so you can close it as a duplicate

If there are other stuff in the summary that are not in #3344542 can you remove stuff that is duplicated in the other issue?

Thanks

Now looking at it more closely I found that the other issue is about the database update warning message and not the summary so removing it .

@yash.rode, ok thanks for updating this issue

related testing result

tedbow → credited bacon → .

@bacon ran into this in 🐛 [DrupalCon] Automatic Updates alpha test result Fixed

The warning message for me was a little unnerving to see the word "failure". As a developer familiar with performing drupal upgrades manually I expect that database upgrades will normally be a part of the upgrade process. Perhaps if the warning is more informational to tell the user about the potential database upgrades and less of a pass/fail message given the user is still able to continue with the automatic update process.

Re #12: in that case, it might make sense for that validator not to make a peep at all, honestly, during a status check.

As @bacon points out, when you have some Drupal experience you expect database updates as a matter of course; quietly redirecting to update.php, if necessary, might be perfectly fine. Or, in the context of a status check, we could simply say "You may be redirected to run database updates", rather than making it sound like a problem.

I discussed this with @tedbow.

My feeling is that we should do the following, and I think Ted agrees:

First, in UpdateReady, we should override getFailureMessageForSeverity() to return NULL if the given $severity is SystemManager::REQUIREMENT_WARNING. Why? Because any warning messages we show in this context, really don't need a preamble. What exactly would we want to say -- "please read the following"? The fact that they are already displayed in a warning message area will draw attention to them.

Secondly, we probably want to change StagedDatabaseUpdateValidator so that, during a status check, it does not actually enumerate the extensions which have DB updates. We should probably just flag a simple message, like "Possible database updates were detected in some modules and themes. Once the update is complete, you may be redirected to another page to run the database updates." Again, though -- this is only during a status check. In any other situation, we DO want the validator to flag an error listing the specific extensions that contained the updates.

Looks good if tests pass! thanks!

Automatically closed - issue fixed for 2 weeks with no activity.