Change sort terminology

Chris-- am I assuming correctly that 'Most popular' would map to the existing 'Active installs' option, and 'Newest first' would map to 'Recently created'?

Thanks!
Bryan

Yes, that's correct @bcgreen!

Tests are failing - we are testing against the language being changed. Please update tests:

1) Drupal\Tests\project_browser\FunctionalJavascript\ProjectBrowserUiTest::testSortingCriteria
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Active installs'
+'Most Popular'

2) Drupal\Tests\project_browser\FunctionalJavascript\ProjectBrowserUiTest::testMultiplePlugins
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'9 Results Sorted by Active installs'
+'9 Results Sorted by Most Popular'

Please review.

Change makes sense and issue fork works.

Marking as RTBC.

Thanks, all!

Automatically closed - issue fixed for 2 weeks with no activity.