- 🇺🇸United States kevinting
I am working on this issue as part of DrupalCon Pittsburgh
- Assigned to kevinting
- last update
over 1 year ago Custom Commands Failed - @kevinting opened merge request.
- Status changed to Needs review
over 1 year ago 7:57pm 7 June 2023 - 🇺🇸United States kevinting
Added Merge Request. Solution is to just wrap the Image element with anchor tag linking to project page.
@earthday47 is willing to add tests as needed.Changes committed to branch 3311992-make-image-clickable-pittsburgh2023
- First commit to issue fork.
- last update
over 1 year ago 65 pass - 🇺🇸United States kevinting
Thanks @fjgarlin for re-pushing commits and running tests.
- First commit to issue fork.
- last update
over 1 year ago 36 pass, 3 fail - 🇺🇸United States earthday47 New York
Hi all! Catching up on this issue's history, I do see that we wanted to have the top region clickable for accessibility reasons. I didn't want our work from yesterday to invalidate all of this useful work, so I rebased the 2nd-to-last MR/branch.
So we have a couple options... the a wrapping the Image element, which would create two anchors to tab through, or the original approach creating a click event/action on the wrapping div.
- 🇺🇸United States chrisfromredfin Portland, Maine
I definitely prefer "the original approach creating a click event/action on the wrapping div." 2 click targets makes less sense especially for a non-sighted user.
- 🇪🇸Spain fjgarlin
It'd also be great to close the MRs that are no longer used.
- last update
over 1 year ago 36 pass, 3 fail - First commit to issue fork.
- last update
over 1 year ago 36 pass, 4 fail - last update
over 1 year ago 36 pass, 4 fail - Status changed to Needs work
over 1 year ago 8:16am 29 June 2023 - First commit to issue fork.
- Merge request !468Updated Grid UI to include both title and logo in an A tag. Working on creating tests presently. → (Open) created by MrMason
- Assigned to MrMason
- Status changed to Needs review
7 months ago 10:40pm 8 May 2024 - 🇺🇸United States MrMason
This is now ready to be reviewed. A tag wraps around the title and logo image. Tests are properly processing this.
- Status changed to Needs work
7 months ago 9:57pm 9 May 2024 - 🇺🇸United States mherman-pro
This change causes the Module title to be center aligned to the image on the list view creating white space above and below the title.
Proposed solution is shrinking the image on the list view and sudo-list view, for small screens, so the title has better alignment and it is more consistent with the size used on drupal.org
There is also white space that appears on some screen widths to the left of the image.
The image and title also gets pushed to the left on the sudo-list view on small screens. (happens if you leave the view on "grid" but then shrink the screen)
- 🇺🇸United States MrMason
I've updated the code to make the list view function properly.
I'm trying to figure out the best way to handle it changing from grid and then back to list when you change the size of the display. I'll keep working on that issue or make it a separate issue from this one.
- Status changed to Needs review
6 months ago 4:01pm 16 May 2024 - 🇦🇺Australia sime Melbourne
I applied this and I can click the icon. I had a look at the failing tests and wasn't able to establish why they are failing, for example this line is failing
$this->svelteInitHelper('text', 'Dancing Queen');
which suggests a11y issue in the style/dom? - Status changed to Needs work
6 months ago 6:54pm 18 May 2024 - 🇺🇸United States MrMason
@Sime the tests for this can be a bit janky. You may have to run it more than once to get it to show up. When I was running these in the past it would sometimes run the tests so fast that not everything had loaded in properly.
I'm going to look at the grid layout issues again this weekend.
- 🇮🇳India prashant.c Dharamshala
+1 for this. Images in the results should be clickable and take the user to the module's detail page.
- First commit to issue fork.
- Status changed to Needs review
5 months ago 10:39am 17 June 2024 - Status changed to Needs work
5 months ago 11:26am 17 June 2024 - 🇮🇳India Kanchan Bhogade
Tested MR 468 on Drupal 11
Images in the results should be clickable, and the user should be taken to the module's detail page.
this is +1
Adding Screen recording for referencebut In the issue summary, MR is "Open Failed pipeline"
moving to "needs work"