Account created on 29 November 2006, about 18 years ago
#

Merge Requests

Recent comments

πŸ‡¨πŸ‡¦Canada zetagraph

Tested locally, things look good. RTBC

πŸ‡¨πŸ‡¦Canada zetagraph

Added a margin to bulk-actions bar when it reaches the bottom of the content so that it's separated from the rest of the cards.

πŸ‡¨πŸ‡¦Canada zetagraph

zetagraph β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada zetagraph

Closing as duplicate. See previous comment. Fix provided in another issue/branch:

https://www.drupal.org/project/gin/issues/3499417 πŸ› Project Browser CSS minor fix Active

πŸ‡¨πŸ‡¦Canada zetagraph

Tested locally. No duplicate description. Ready to merge.

πŸ‡¨πŸ‡¦Canada zetagraph

This is addressed in here: https://www.drupal.org/project/gin/issues/3499417 πŸ› Project Browser CSS minor fix Active

We should close this. Let me know if there are any objections.

πŸ‡¨πŸ‡¦Canada zetagraph

Reviewed Search icon overlap fix and things look good.

While in there, I've made a small tweak to the "security" icons, as they were not consistent in sizing.

πŸ‡¨πŸ‡¦Canada zetagraph

zetagraph β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada zetagraph

Should the spacing issue be addressed specifically in GIN's `poroject_browser` components instead of the `pb.css`. It introduces extra space in Claro.


πŸ‡¨πŸ‡¦Canada zetagraph

All good, thanks for letting me know @gΓ‘bor-hojtsy and thanks for connecting @pameeela.

πŸ‡¨πŸ‡¦Canada zetagraph

I've increased the label target area.

One thing I noticed is that the first input gets automatic focus and stays that way unless you click outside the dropdown.

Probably an issue that needs to be addressed separately and in conjunction with "onBlur" event handling in Svelte.

πŸ‡¨πŸ‡¦Canada zetagraph

@tabestan, @rkoller we are rearranging things visually in this issue πŸ“Œ Improve the categories filter type in context to the rest of the filter component ui Fixed

The search box is going to always span the full width of the browser window. There is no need to limit the box width or the character count as far as I can tell.

CC: @raubin, @gauravvvv

πŸ‡¨πŸ‡¦Canada zetagraph

I've pushed a few updates to the `3318817-change-catfilter-for-2x` branch:

  • Added focus state (accessibility)
  • Updated markup and labels (accessibility)
  • Improved and updated styles for the dropdown and checkboxes

This is the current state of things:

@sime can you help with number 3 in comment #27 for the off-focus/onBlur in Svelte. We just want to close the dropdown on click outside. Thank you.

πŸ‡¨πŸ‡¦Canada zetagraph

@rkoller thank you for the feedback. Here are the latest changes, based on your feedback and the conversation we had in UX meeting today.

  • Rearranged the search and filters
  • Removed the Media Query that was hiding categories on mobile
  • Updated Styles

πŸ‡¨πŸ‡¦Canada zetagraph

I've pushed some tweaks and updates to responsive style. Filters should look much better for mobile/tabletish breakpoints now. Also made some stylistic changes, but things still needs additional UI tweaks.

Couple of things I was wandering about while looking at this:

- There is some breakpoint based logic with the Categories Filter in Svelte. It is being hidden on mobile. Assuming we need to take that logic out.

- Wondering if the "Filter by Category" and "Keyword Search" should be swapped. Making the "Keyword Search" fist form item. Just a thought.

πŸ‡¨πŸ‡¦Canada zetagraph

@thejimbirch thanks for clarifications. Apologies if this confuses things. I was just trying to see if I can help with the visuals/graphics.

Adding a link to a conversation that was also happening in Slack here

Also, here are some "default logo" variations based on ^ that conversation:

πŸ‡¨πŸ‡¦Canada zetagraph

Here is an idea for the placeholder / "don't have an icon" logo.

Using the colors from the new Brand Guidelines β†’ .

πŸ‡¨πŸ‡¦Canada zetagraph

Just wanted to make a few clarifications:

1. For the visuals/logos, do we need something fairly abstract or more indicative of the type of recipe? For example, the Starshot wires have 6 categories with a graphic representation/logo/icon. Should we continue with these type of visuals or be more abstract? It might be really hard to represent a specific recipe with an icon/logo.

2. Assuming recipes loaded through the Project Browser interface, and we are sticking to the card format that β€œregular modules” in Project Browser have? I am aware of the 512x512 PNG requirement, just wanted to confirm where these logos be showing.

3. Do we need a β€œdefault” logo/icon for the Recipes that will not have any visual? Sort of like an empty puzzle piece in Project Browser card?

4. Created a few quick visuals to get started with design direction. Note, intentionally staying away from cooking concepts and keeping things fairly abstract.

πŸ‡¨πŸ‡¦Canada zetagraph

Is PNG the only format? SVGs will look sharper and cleaner for vector based graphics. Or is there a technical limitation for use of SVGs here?

Production build 0.71.5 2024