- Issue created by @chrisfromredfin
- Merge request !568Issue #3499417: Project Browser CSS minor fix โ (Merged) created by Unnamed author
- ๐ฎ๐ณIndia sandip
Please review the changes. I have attached before and after Screenshots for reference.
- ๐จ๐ญSwitzerland saschaeggi Zurich
The search icon seems misaligned and not the remove button
- ๐ฎ๐ณIndia sandip
I have added some padding in the search icon. Can you verify the alignment once.
- ๐บ๐ธUnited States mcgovernm North Carolina
Looks like the CSS change was missing from the scss file, build is now passing. Marking as needs review.
- First commit to issue fork.
- ๐จ๐ฆCanada zetagraph
Reviewed Search icon overlap fix and things look good.
While in there, I've made a small tweak to the "security" icons, as they were not consistent in sizing.
- ๐ฎ๐ณIndia sandip
HI @zetagraph,
Thank you for identifying the issue with the size of the security iconsโI appreciate your attention to detail. However, I believe this might not be directly related to the current issue. I belive we could keep this issue only for fixing the overlap issue of search icon and cross icon. Perhaps we could create a separate issue specifically for this?Please feel free to share your perspective and correct me if Iโm mistaken as i am very new to contribution.
- ๐ฎ๐ณIndia sandip
Increase the inset-inline-end more on `#project-browser .search__search-clear` as it was still overlapping with search icon when it gets focus.
tomislav.matokovic โ made their first commit to this issueโs fork.
I have successfully replicated this issue and tested the solution.
-
saschaeggi โ
committed 832960ec on 4.0.x authored by
sandip poddar โ
Issue #3499417: Project Browser CSS minor fix
-
saschaeggi โ
committed 832960ec on 4.0.x authored by
sandip poddar โ
- ๐จ๐ญSwitzerland saschaeggi Zurich
Thanks for working on this, I've pushed some more fixes and made some slight adjustments but overall it looked great ๐๐ค
- ๐จ๐ญSwitzerland saschaeggi Zurich
Included in the 4.0.4 release: https://www.drupal.org/project/gin/releases/4.0.4 โ
Automatically closed - issue fixed for 2 weeks with no activity.