mcgovernm → changed the visibility of the branch drupal-3502014-3502014-clean-up-hook to hidden.
Tests started failing after adding the return type to hook_help in this commit. I have not been able to figure out why this would change anything.
Time: 00:37.972, Memory: 4.00 MB
There was 1 failure:
1) Drupal\Tests\navigation\FunctionalJavascript\PerformanceTest::testLogin
Failed asserting that 61 is identical to 60.
/var/www/html/core/modules/navigation/tests/src/FunctionalJavascript/PerformanceTest.php:75
Line 75 of PerformanceTest.php:
$this->assertSame(60, $performance_data->getCacheGetCount());
mcgovernm → created an issue.
mcgovernm → made their first commit to this issue’s fork.
@HeikkiY @smustgrave I was poking around with this locally, also using ddev-drupal-core-dev and found that my test was failing when navigating to '/pager-test/ellipsis'. I was receiving an error that the watchdog table didn't exist. I left a comment on the MR, but I believe the dependency on dblog is required. This is passing for me locally with the dependency added back.
Looks like the CSS change was missing from the scss file, build is now passing. Marking as needs review.
The build is failing with "Error: Uncommitted Changes Detected". Setting this back to needs work.
Fix for phpcs error.