Added patch in #41 as MR, tests are passing, ready for review.
mcgovernm → changed the visibility of the branch 11.x to hidden.
mcgovernm → changed the visibility of the branch 2755791-ajax-error-ajax.form.ajaxsubmit to hidden.
mcgovernm → changed the visibility of the branch 2755791-jquery_form_js_weight to hidden.
mcgovernm → changed the visibility of the branch 2755791-jquery-form-js-weight to hidden.
mcgovernm → changed the visibility of the branch 2755791-jquery-form-js-weight to hidden.
mcgovernm → made their first commit to this issue’s fork.
The link to "Add new tests" under "Upload a test case that fails" was linking to the 'edit page' for the node instead of the node itself. Updated the link to remove '/edit'.
Thank you @berdir. I've created a new branch and on it rolled back the commit that moved it to a service. New draft MR is here. Hopefully I've deprecated these correctly, I assume we'll need to update the CR to indicate these have been moved to protected methods?
Thank you @berdir! I've just pushed a commit to address that. I also noticed we still need to remove taxonomy_build_node_index and taxonomy_delete_node_index from taxonomy.module since they've been moved to TaxonomyEntityHooks. I should be able to get to that shortly.
Thanks for the feedback! I think it was just two classes that needed to be renamed based on the text file, this is ready for review.
Thanks! This is ready for review again. I had moved the setting of $config to a helper function, but wasn't sure after the last couple of comments if that was necessary or if it could have been left in the constructor for this case.
mcgovernm → changed the visibility of the branch 11.x to hidden.
mcgovernm → changed the visibility of the branch 3502014-clean-up-hook to hidden.
Putting back to needs work, as taxonomy_theme_suggestions_taxonomy_term still needs to be addressed.
mcgovernm → changed the visibility of the branch drupal-3502014-3502014-clean-up-hook to hidden.
Tests started failing after adding the return type to hook_help in this commit. I have not been able to figure out why this would change anything.
Time: 00:37.972, Memory: 4.00 MB
There was 1 failure:
1) Drupal\Tests\navigation\FunctionalJavascript\PerformanceTest::testLogin
Failed asserting that 61 is identical to 60.
/var/www/html/core/modules/navigation/tests/src/FunctionalJavascript/PerformanceTest.php:75
Line 75 of PerformanceTest.php:
$this->assertSame(60, $performance_data->getCacheGetCount());
mcgovernm → created an issue.
mcgovernm → made their first commit to this issue’s fork.
@HeikkiY @smustgrave I was poking around with this locally, also using ddev-drupal-core-dev and found that my test was failing when navigating to '/pager-test/ellipsis'. I was receiving an error that the watchdog table didn't exist. I left a comment on the MR, but I believe the dependency on dblog is required. This is passing for me locally with the dependency added back.
Looks like the CSS change was missing from the scss file, build is now passing. Marking as needs review.
The build is failing with "Error: Uncommitted Changes Detected". Setting this back to needs work.
Fix for phpcs error.