Clean up hook implementations in the Taxonomy module

Created on 24 January 2025, 4 days ago

Problem/Motivation

Hooks should be updated to match grouping standards in [meta] Standardize and clean up hook classes in core πŸ“Œ [meta] Clean up hook classes in core Active .

Steps to reproduce

n/a

Proposed resolution

Split out the TaxonomyHooks class, making theme and help new single hook classes, and entity actions a new grouped hook class.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Active

Version

11.1 πŸ”₯

Component

taxonomy.module

Created by

πŸ‡ΊπŸ‡ΈUnited States mcgovernm North Carolina

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mcgovernm
  • Pipeline finished with Success
    4 days ago
    Total: 652s
    #405007
  • Pipeline finished with Success
    4 days ago
    Total: 1305s
    #405046
  • πŸ‡ΊπŸ‡ΈUnited States mcgovernm North Carolina
  • πŸ‡¬πŸ‡§United Kingdom oily Greater London
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    @oily, please make sure when you're editing the issue summary you're reviewing what is actually needed, there are definitely remaining tasks for this issue, they are just not added yet.

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    @mcgovernm this is a great first step!

    I think there are a couple of things we want to do in these that we wouldn't normally do for organization since they are hooks.

    1. Add the appropriate return types for the methods if they do not exist.
    2. Add dependency injection.

    These are autowired, in case you are not familiar with in general it means you should be able to just add a use statement for the interface of the service you need, then add that service to the constructor.

    Let me know if you have any questions!

    I'll take a deeper look later.

  • Pipeline finished with Failed
    4 days ago
    #405079
  • Pipeline finished with Failed
    4 days ago
    Total: 164s
    #405103
  • πŸ‡³πŸ‡ΏNew Zealand quietone
  • πŸ‡ΊπŸ‡ΈUnited States mcgovernm North Carolina
  • Pipeline finished with Success
    4 days ago
    Total: 648s
    #405109
  • πŸ‡¬πŸ‡§United Kingdom oily Greater London

    @nicxvan wrt #5

    @oily, please make sure when you're editing the issue summary you're reviewing what is actually needed, there are definitely remaining tasks for this issue, they are just not added yet.

    I did not edit 'Remaining tasks'. It is blank. If you are referring to the other fields, I filled them based on what I thought appropriate. 'None' could be thought of as 'None' ever or 'None' just now.

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    You did add none to remaining tasks, I removed it in comment 5.

    You did the same in this issue here too: πŸ“Œ Drupal\Core\Theme\ComponentNegotiator::negotiate uses a lot of memory Active

    I agree keeping issue summaries up to date is useful, I'm not trying to discourage you from updating them.

    I am trying to encourage you to review the actual issue and provide relevant updates.

    There are remaining tasks both in this issue and the other, no need to write them or if you don't know what they are, but none is not accurate.

  • πŸ‡¬πŸ‡§United Kingdom oily Greater London

    @nicxvan RE: #10 I did not realise you had had to redo. I dont want to create work for others. So I agree, I will be more circumspect about completing issue summaries.

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    taxonomy_theme_suggestions_taxonomy_term can be manually converted, the rector rule missed all theme suggestions.

  • Pipeline finished with Running
    3 days ago
    Total: 1300s
    #405885
  • Pipeline finished with Failed
    1 day ago
    Total: 520s
    #407584
  • Pipeline finished with Failed
    1 day ago
    Total: 4370s
    #407582
  • Pipeline finished with Failed
    about 5 hours ago
    Total: 487s
    #408515
Production build 0.71.5 2024