Drupal\Core\Theme\ComponentNegotiator::negotiate uses a lot of memory

Stumbled over this as well, thanks to 📌 Aggregate cache operations per bin to allow for more specific asserts Active

The module weight is stable, unlike the active theme, it doesn't change at runtime. We can sort the whole component list once by module weight and then negotiate doesn't actually need to do any negotiation, it can just return the first. We might need a cache tag on config:core.extension in case a module weight changes.

Also didn't check tests yet nor did I properly inject the module extension list.

Added a review comment to the MR.

Improved the comment and updated the cache assertions.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

It's been a while since I was in this code, but everything checks out. Bear in mind that I reviewed this on my phone without access to the full codebase.

It'd be nice to have @pdureau's confirmation.

pdureau → credited grimreaper → .

Reviewed by @e0ipso.

Reviewed by @grimreaper on behalf of @pdureau

Ok for us

The updated performance tests show that we no longer request that cache on that page, yes. We also have performance graphs that should show the memory savings over time once committed, but we do not assert on time/memory explicitly as it's too fragile.

Thanks this looks great, and really nice that we have a way to test for it now, if not the memory improvement directly.

Committed/pushed to 11.x thanks!

catch → closed merge request !10987

Automatically closed - issue fixed for 2 weeks with no activity.