- Issue created by @pameeela
- First commit to issue fork.
- Merge request !670#3498901 :Recipe description appears twice in modal → (Open) created by utkarsh_33
- 🇮🇳India Kanchan Bhogade
Hi
I've tested MR !670 on Drupal 11.x
The MR is applied successfully...Testing steps:
Install Drupal 11.x
Go to the recipes page
Click on a recipe
See the description appears twice
Applied MR and checked for sameTest Result:
Recipe description appears twice in modal issues is resolvedAttaching Screenshots
RTBC+1Keeping need review for code verification!
- 🇬🇧United Kingdom dunx
Tested on drupal_cms dev.
Steps using ddev to reproduce:
- git clone https://git.drupalcode.org/project/drupal_cms.git
- cd drupal_cms
- ddev config --project-type=drupal11 --docroot=web --php-version=8.3
- ddev start
- ddev composer install
- ddev launch
Followed be skip of available recipe installation and minimum setup.
Project recipes page at /admin/modules/browse/recipes currently looks like this:
Ah, looks like this is already fixed in dev! Well, I'll leave this here just in case. Nice work. Looking forward to the launch party in London tomorrow :)
- 🇬🇧United Kingdom dunx
Tested on drupal_cms dev.
Steps using ddev to reproduce:
- git clone https://git.drupalcode.org/project/drupal_cms.git
- cd drupal_cms
- ddev config --project-type=drupal11 --docroot=web --php-version=8.3
- ddev start
- ddev composer install
- ddev launch
Followed be skip of available recipe installation and minimum setup.
Visit project recipes page at /admin/modules/browse/recipes and then click on a recipe.
The *modal* looks like this:
Applied patch:
ddev composer require 'drupal/project_browser:2.0.x-dev'
ddev composer config repositories.project_browser vcs https://git.drupalcode.org/issue/project_browser-3498901.git
ddev composer require drupal/project_browser:dev-3498901-recipe-description-appearsHmmm... MR not applying:
Your requirements could not be resolved to an installable set of packages. Problem 1 - Root composer.json requires drupal/drupal_cms_starter 1.x-dev -> satisfiable by drupal/drupal_cms_starter[1.x-dev]. - drupal/drupal_cms_starter 1.x-dev requires drupal/project_browser ^2-alpha7 -> found drupal/project_browser[2.0.0-alpha7, 2.0.x-dev] but it conflicts with your root composer.json require (3498901-recipe-description-appears-dev).
Is that an issue with the MR or (more likely I'll happily admit), a problem with me?
- 🇬🇧United Kingdom dunx
Okay, I tried this:
ddev composer require drupal/project_browser:"dev-3498901-recipe-description-appears as 2.0.7-alpha7"
(Thanks the_g_bomb)A quick refresh and now the Recipe modal looks like this:
Looks fixed to me so another for RTBK.