- Issue created by @utkarsh_33
- Merge request !697#3502986: Remove #project-browser from CSS and use more specific selectors. → (Merged) created by utkarsh_33
- 🇺🇸United States phenaproxima Massachusetts
I'm a little concerned about the use of positional selectors - that makes the styling very vulnerable to slight changes in markup, and without visual regression testing, it's way too liable to break randomly on us.
- 🇮🇳India utkarsh_33
Removed the fragile selector as i completely agree with @phenaproxima.It's up for another round of review and some manual testing.
- 🇺🇸United States phenaproxima Massachusetts
I mean...that CSS looks fine to me! 🎉
I'll tentatively mark this RTBC, hopefully @chrisfromredfin and/or @narendrar can kick the tires a bit to see if we accidentally regressed anything.
- 🇺🇸United States chrisfromredfin Portland, Maine
Moving to NW just to get an answer to my question about that other class. but it may be out of scope for this issue .
- 🇮🇳India utkarsh_33
I have changed the selector coming from upstream with the selector in our scope.Marking it NR again.
- 🇺🇸United States phenaproxima Massachusetts
The code looks good to me, so I am tentatively RTBCing this, but it will need some pretty solid manual testing from someone who is more familiar with the look of this module than I am.
- 🇨🇦Canada zetagraph
Manually tested in Claro and Gin theme. No visual regressions.
-
chrisfromredfin →
committed 5f0ee417 on 2.0.x authored by
utkarsh_33 →
Issue #3502986 by utkarsh_33, chrisfromredfin, zetagraph, phenaproxima:...
-
chrisfromredfin →
committed 5f0ee417 on 2.0.x authored by
utkarsh_33 →
- 🇺🇸United States chrisfromredfin Portland, Maine
documenting here that the animation thing seems a little changed after my rebase, but I think it was correct based on past diffs of Utkarsh's work.
Automatically closed - issue fixed for 2 weeks with no activity.