Remove #project-browser from CSS and use more specific selectors.

Created on 29 January 2025, 5 months ago

Problem/Motivation

Change UI for the install queue to match bulk operations 📌 Change UI for the install queue to match bulk operations Active introduced usage of #project-browser id for targeting selectors and styling them,but that's not the best way to do that.
We should make use of Specificity to target elements.

Steps to reproduce

Proposed resolution

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇮🇳India utkarsh_33

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @utkarsh_33
  • Pipeline finished with Failed
    5 months ago
    Total: 505s
    #408936
  • Pipeline finished with Success
    5 months ago
    Total: 783s
    #408945
  • Pipeline finished with Success
    5 months ago
    Total: 404s
    #408960
  • 🇺🇸United States phenaproxima Massachusetts

    I'm a little concerned about the use of positional selectors - that makes the styling very vulnerable to slight changes in markup, and without visual regression testing, it's way too liable to break randomly on us.

  • 🇮🇳India utkarsh_33

    Removed the fragile selector as i completely agree with @phenaproxima.It's up for another round of review and some manual testing.

  • Pipeline finished with Success
    5 months ago
    Total: 756s
    #415644
  • Pipeline finished with Success
    5 months ago
    Total: 485s
    #415655
  • 🇺🇸United States phenaproxima Massachusetts

    I mean...that CSS looks fine to me! 🎉

    I'll tentatively mark this RTBC, hopefully @chrisfromredfin and/or @narendrar can kick the tires a bit to see if we accidentally regressed anything.

  • 🇺🇸United States chrisfromredfin Portland, Maine

    Moving to NW just to get an answer to my question about that other class. but it may be out of scope for this issue .

  • 🇮🇳India utkarsh_33

    I have changed the selector coming from upstream with the selector in our scope.Marking it NR again.

  • Pipeline finished with Success
    5 months ago
    Total: 607s
    #423114
  • 🇺🇸United States phenaproxima Massachusetts

    The code looks good to me, so I am tentatively RTBCing this, but it will need some pretty solid manual testing from someone who is more familiar with the look of this module than I am.

  • 🇨🇦Canada zetagraph

    Manually tested in Claro and Gin theme. No visual regressions.

  • Pipeline finished with Canceled
    5 months ago
    Total: 382s
    #427875
  • Pipeline finished with Success
    5 months ago
    Total: 490s
    #427880
  • Pipeline finished with Skipped
    5 months ago
    #427891
  • 🇺🇸United States chrisfromredfin Portland, Maine

    documenting here that the animation thing seems a little changed after my rebase, but I think it was correct based on past diffs of Utkarsh's work.

  • Pipeline finished with Canceled
    5 months ago
    Total: 859s
    #433060
  • Pipeline finished with Success
    5 months ago
    Total: 2075s
    #433066
  • Pipeline finished with Success
    5 months ago
    Total: 1347s
    #433084
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    8 days ago
    Total: 252s
    #538842
Production build 0.71.5 2024