🇺🇸United States @MrMason

MrMason → created an issue.

@Sime the tests for this can be a bit janky. You may have to run it more than once to get it to show up. When I was running these in the past it would sometimes run the tests so fast that not everything had loaded in properly.

I'm going to look at the grid layout issues again this weekend.

I don't think we should be removing the (mocked) from the Drupal.org tab at this time. The reason that we have the "(Mocked)" text is because we don't currently have a json api endpoint to pull the projects so we have a mock endpoint which is just a flat json file in the project.

After we have the endpoint I think we should move forward, but until that time we should continue to note that it's mock data.

I've updated the code to make the list view function properly.

I'm trying to figure out the best way to handle it changing from grid and then back to list when you change the size of the display. I'll keep working on that issue or make it a separate issue from this one.

I'll update this today.

I'm of the opinion that having a title and alt tag for an icon is more than enough. Adding a legend just clutters the display.

If we wanted to have easily visible text a hover effect where hovering over an icon would reveal text could be an option, but I feel that for now an alt and title are more than enough.

This was erroring when rendering components. Updated the code to be slightly less buggy.

MrMason → made their first commit to this issue’s fork.

MrMason → created an issue.

The content here looks correct. The highlighting of the radio button matches the styling for Claro.

This is now ready to be reviewed. A tag wraps around the title and logo image. Tests are properly processing this.

MrMason → made their first commit to this issue’s fork.

Until the Project Browser has a way for me to view the already enabled projects I don't believe that we should make the browse the default tab for Extend. If Project Browser shifts in such a way that it can replicate the "What modules do I have and are they enabled" functionality then I'd be in favor of it being the default tab.

Your average interaction with extend is going to continue be enabling modules the user already has.

From my experience for 508 compliance, we need to use the alt tag. When a screen reader reads the site it's going to use the alt tag and if the image doesn't load it's going to display the alt information not the title information.