- First commit to issue fork.
- Merge request !470add classes to filter radio buttons to match claro theme β (Merged) created by mherman-pro
- Status changed to Needs review
8 months ago 10:40pm 8 May 2024 - πΊπΈUnited States mherman-pro
Added the classes that were being used by the Claro theme to the radio button so that it would get the same styles applied.
- Assigned to mherman-pro
- πΊπΈUnited States MrMason
The content here looks correct. The highlighting of the radio button matches the styling for Claro.
- Status changed to RTBC
8 months ago 10:56pm 8 May 2024 - πΊπΈUnited States chrisfromredfin Portland, Maine
chrisfromredfin β changed the visibility of the branch 3293899-focus-outlines-for to hidden.
- Status changed to Needs review
8 months ago 3:55pm 9 May 2024 - πΊπΈUnited States chrisfromredfin Portland, Maine
Ralf - since you had such a nice thorough plan here, if you want to try this out in GitPod that would be fun. :)
I was able to check it out in Safari and Chrome at least and it looks good - but if I had your blessing I'd feel better about this one. :)
- Status changed to Needs work
8 months ago 4:30pm 9 May 2024 - π©πͺGermany rkoller NΓΌrnberg, Germany
i've applied MR470 locally. If you take a look at the radio button section first on https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/π§-Drupal-Design-system?type=design&node-id=553-0&mode=design&t=fKFt7DZuX3hQR6Ts-0 and then in gitpod or in your local instance you will notice that there is a divergence. :/
in safari you notice for example that the radio element has only a height of 12x12 , the goal should be 19x19 according to the drupal design system. styling wise it also differs, the center for selected radio buttons are filled in blue then a white ring then another blue one, plus the focus outline is completely missing in safari 17.4.1 on macos 14.4.1.
in edge the element is one pixel "bigger" compared to safari with 13x13. the styling has the same problems like in safari only difference the color is greyish instead of blueish.
and the focus outline is visible in edge, the styling is also not inline with the design system. the outline is a rectangle but it should be a circle according to the figma file:
- Status changed to RTBC
7 months ago 4:50pm 5 June 2024 - π©πͺGermany rkoller NΓΌrnberg, Germany
uhhh took another look after @chrisfromredfin mentioned the issue on slack. i thought it wouldnt be needed after MRs were successfully applied, but somehow none of the changes were in place still. but running
yarn install
andyarn build
did the trick. completely forgot about that :( but all the changes look good now and setting to rtbc - Status changed to Fixed
7 months ago 12:16am 6 June 2024 - πΊπΈUnited States chrisfromredfin Portland, Maine
Big victory! This one's been lingering a while. I like it when classes fix the issue. :)
-
chrisfromredfin β
committed 0d839d30 on 1.0.x authored by
mherman-pro β
Issue #3293899 by mherman-pro, chrisfromredfin, Ruturaj Chaubey, rkoller...
-
chrisfromredfin β
committed 0d839d30 on 1.0.x authored by
mherman-pro β
Automatically closed - issue fixed for 2 weeks with no activity.