Make PB menu items behave similar to their siblings

Created on 1 May 2024, 2 months ago
Updated 23 May 2024, about 2 months ago

Problem/Motivation

Project Browser is the only local item listed as a submenu item of the extend top level menu item with the navigation module

With Project Browser installed the top level menu item for the extend page behaves differently compared to for example people. For people you only have the top level menu item in the navigation module sidebar. when you click it you get to the people page with the local items list, permissions, roles and role settings. when you click the extend top level menu item instead, the draw expands and shows the submenus:

to reach the list of installed modules you have to click the extend title within the drawer or you have the option to click the only submenu available browse modules. as soon as you are on the project browser page that makes the local items list , update , browse , and uninstall available/reachable. so project browser is breaking with the interface convention here exposing the browse modules sub menu item to the navigation.

Steps to reproduce

since project browser is unavailable for drupal 11.x and navigation went into core a few days ago as experimental module it is impossible to test against the latest version in core but it is possible to install the navigation contrib module https://www.drupal.org/project/navigation โ†’ alongside project browser

Proposed resolution

hide the browse modules sub menu item so that only the top level menu item extend is available and no drawer expands for the extend top level menu item.

๐Ÿ“Œ Task
Status

Fixed

Version

1.0

Component

User experience

Created by

๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @rkoller
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States chrisfromredfin Portland, Maine

    We need to make the Browse tab the default for Extend, so this will probably be cleaned up along with that. Related to ๐Ÿ“Œ Project browser September 2023 usability testing results with the University of Minnesota Active

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

    hm i am not sure if i would agree on making the browse tab the actual default for the extend top level menu item.

    first what were the actual tasks / objectives the users had to solve during the tests? the linked issue only provides a summary of the identified issues and some general feedback. and have the sessions been recorded?

    about the suggestion. i agree that the local task label "list" is sort of unclear in particular in combination with browse next to it in case you dont know the underlaying functionality of project browser yet. that has room for improvements. but i am really not sure if making the browse tab the actual default is necessarily the solution for the actual problem. is the project browser page the most frequently used page is the main reason someone visits the extend top level menu item to search and install a new module?! that is the detail i am uncertain about. from my personal perspective when i visits the extend page i want to get to the overview of installed modules. Maybe rethink local task labels instead and fine more clear labels for list and browse?

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States chrisfromredfin Portland, Maine
  • hide the browse modules sub menu item so that only the top level menu item extend is available and no drawer expands for the extend top level menu item.

    I agree with this proposed resolution. It also keeps the "Extend" menu on par with the "Appearance" menu, and that seems nice in its consistency.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States MrMason

    Until the Project Browser has a way for me to view the already enabled projects I don't believe that we should make the browse the default tab for Extend. If Project Browser shifts in such a way that it can replicate the "What modules do I have and are they enabled" functionality then I'd be in favor of it being the default tab.

    Your average interaction with extend is going to continue be enabling modules the user already has.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States MikeTullo

    I like the idea of having Extend act functionally the same as Appearance. That would make a consistent experience for users and lead to less confusion. However, I agree with others that the main use case seems to be "what modules do I have installed/enabled?".

    If Project browser becomes the default tab for Extend, it should show which modules are enabled (which I think could be the best of both worlds). If it doesn't I would say keep the current state of Extend.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dblanken

    I believe that unless Project Browser can function in the same way letting you know what's been enabled, it should not be the default for Extend. If the issue is the lone menu link, would it be beneficial to have menu links there to the subtabs (Uninstall, etc.)? Saves a click and allows "Browse modules" to not be alone.

  • First commit to issue fork.
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States johnpicozzi Providence, RI

    Created an MR that just removes the menu item. I don't really agree that the extend menu item should go to the browse tab directly. However, the MR provided removed the menu link and thus removes the slide out menu.

  • Pipeline finished with Success
    2 months ago
    Total: 383s
    #168118
  • Status changed to Needs review 2 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States johnpicozzi Providence, RI

    @rkoller Do you think removing the sub-menu item for extend resolves the issue? If so this could be moved to RTBC. Thanks!

  • Status changed to RTBC 2 months ago
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

    thx for the MR @johnpicozzi! from my perspective it would resolve the issue, and was also my proposed resolution. I've also manually tested the change by installing the discontinued navigation contrib module, since project browser isnt compatible with drupal 11 yet, and applied the MR. Looks good that way. I think defaulting to the list page, when top level menu item for extend is clicked, is the preferable choice. I would suggest to open up a follow up issue about the tab labels for the local tasks list and browse to make their purpose more clear and tackle the issue people had at the user testing at the university of minnesota. Since the MR only removed a few lines in the yaml file i suppose no code review is required (i would not be qualified for that), therefore i'll set the status to rtbc

  • Pipeline finished with Skipped
    2 months ago
    #168869
  • Pipeline finished with Skipped
    2 months ago
    #168870
  • Status changed to Fixed 2 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States chrisfromredfin Portland, Maine

    I agree after thinking more; plus getting such great feedback from the community! This is a separately-scoped issue which I'm going to merge; I'm going to open a follow-on for "consider if Browse should be the default tab for Extend" and get community feedback on it.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024