hestenet → credited rosiel → .
I'm revisiting this as it's desired by the Islandora community.
Is it possible to add tests for a field type that's defined by another module? I don't think further tests are possible unless we mock up a shim for the 'typed_relation' field type. That seems like overkill...
Alternately, instead of testing $field_definition->getType(), we could test is_a($fieldDefinition->getClass(), 'Drupal\Core\Field\EntityReferenceFieldItemList', true). That would work both for entity reference fields and any field type that extends entity reference, including typed relation. This might prevent the need for any additional tests.
This patch does not allow us to create image style derivatives.
On line 132, we need to set `required_derivative_scheme' => $scheme,` not 'public' in order for image styles to work when we're using a flysystem scheme.
In parallel, we're lacking a "place a block in [region-list]" action in ECA, but I'm not sure if they could share any implementation details?
I have managed such mischief using Twig Tweak. With that module enabled, I can use the ECA "Render: Twig" Action, and following
Twig Tweak's Rendering Blocks instructions →
I can enter something like:
{{ drupal_block('my_block_plugin_id', { some_setting: 'Text including tokens like [node:title]!', }) }}
In twig tweak 3.3.0, it appears the setting of the block's label in {{ drupal_block }} is broken, so that's sadly not an option.
For my use case, it would be nicer to have the Block configuration form right in ECA, the way (non-preconfigured) Actions can be selected, and have their configuration form display. It would also be nice to have the functionality of rendering a block without relying on an external module. While I'm aiming high, it would be nice as a site builder to see Contextual Links, and for one of those links to be to "Edit block in ECA" since it can often be opaque why a block is showing up where it is.
hide the browse modules sub menu item so that only the top level menu item extend is available and no drawer expands for the extend top level menu item.
I agree with this proposed resolution. It also keeps the "Extend" menu on par with the "Appearance" menu, and that seems nice in its consistency.
Hi @chaitanyadessal, thank you for your excellent MR. I've tested and it works as intended.
I'm sorry to ask this - and we haven't yet put this on the module description - but we do development on this module on Github. Would you be willing to re-create your PR there, and we'll happily merge it. Otherwise, if you want to give an email associated with your Github account, I can make the PR and add you as a co-author.
Either way I will endeavour to make sure you get credit in the drupal.org system!
Hi,
The trouble you’re having is completely understandable. I’ve made some suggestions to our README that I hope will help. You can see the changelog at https://github.com/Islandora/advanced_search/pull/46 and any feedback you have is welcome.
To solve your most recent questions (which are also, I hope, clearer now in the readme):
- we assume you are using an entity reference field on your content type that allows a node to point to its parent node. In the core islandora module it’s called “field_member_of”. You don’t need to call it field member of, if you’re not using islandora.
- the view “solr search content” also comes with the islandora starter site, but it doesn’t have to be that exact view. You just need a Search API view. Unlike the normal process of creating a search api view, you don’t need to add a “full text” exposed filter.
Third, if you want to see it in action, try the islandora sandbox at https://sandbox.islandora.ca
Fourth, if you join our Slack we may be able to provide more real-time assistance. https://www.islandora.ca/community
hestenet → credited rosiel → .
I consent to (encourage!) the transfer of these module to community-islandora. Thanks!
In a similar issue on a different module, @neclimdul proposed using a helper function, user_role_grant_permissions. See
https://www.drupal.org/project/userprotect/issues/3349663#comment-15104566
🐛
Error: Call to a member function grantPermission() on null in userprotect_install()
RTBC
Patch attached.