Drupal 10.3.x: ImageStyleDownloadController::deliver" requires "$required_derivative_scheme"

This patch does not allow us to create image style derivatives.

On line 132, we need to set `required_derivative_scheme' => $scheme,` not 'public' in order for image styles to work when we're using a flysystem scheme.

huhhuh → made their first commit to this issue’s fork.

huhhuh → changed the visibility of the branch 3457193-drupal-10.3.x-imagestyledownloadcontrollerdeliver to hidden.

I was testing the patch from comment #2. The image_style route needs to be defined for each scheme in the loop. I fixed that and created a merge request.

fwiw, I needed to amend https://git.drupalcode.org/project/flysystem/-/merge_requests/57/diffs#2... to be
'required_derivative_scheme' => $scheme ?? 'fedora',
because when running phpunit on other code this function would be invoked with no $scheme defined.
My intervention is a work-around; someone more familiar with the code may have a better approach.

NW based on feedback from @jonathan_hunt

I'm not that familiar with rest of the code, but I'm willing to give this a go, since I would like to see this issue fixed. @jonathan_hunt, I don't fully understand what you are doing and what issue you have.

To me, it sounds like some of your tests are failing. Are the phpunit tests missing some configuration, so that the $scheme variable is NULL? The scheme comes from \Drupal\flysystem\FlysystemFactory::getSchemes(), which ultimately seem to come from Settings::get('flysystem', []). How is the flysystem module configured in your tests?

lhridley → made their first commit to this issue’s fork.

lhridley → changed the visibility of the branch 3457193-required_derivative_scheme to hidden.

Automatically closed - issue fixed for 2 weeks with no activity.

Just commenting for posterity, but: In updating, finding the patch we applied to our environments for this issue (which included both #5 and #11) was no longer applying. It's only #11 that was merged here. #5 left unmerged appears to have popped and appears to have been addressed elsewhere: https://www.drupal.org/project/flysystem/issues/3513799 🐛 Image style generation no longer works for non-local drivers in Active