@oikeuttaelaimille

I'm not that familiar with rest of the code, but I'm willing to give this a go, since I would like to see this issue fixed. @jonathan_hunt, I don't fully understand what you are doing and what issue you have.

To me, it sounds like some of your tests are failing. Are the phpunit tests missing some configuration, so that the $scheme variable is NULL? The scheme comes from \Drupal\flysystem\FlysystemFactory::getSchemes(), which ultimately seem to come from Settings::get('flysystem', []). How is the flysystem module configured in your tests?

huhhuh → created an issue.

I was testing the patch from comment #2. The image_style route needs to be defined for each scheme in the loop. I fixed that and created a merge request.

huhhuh → changed the visibility of the branch 3457193-drupal-10.3.x-imagestyledownloadcontrollerdeliver to hidden.

huhhuh → made their first commit to this issue’s fork.

huhhuh → created an issue.

Hello, we have issues with redirects in 10.3.5. The root cause seems to be #3467860 🐛 Logic error in Drupal's lazy load for asset aggregation Active . However, we also use hook_file_url_alter to modify assets URLs, so the redirect destination is broken for us. I created #3475639 🐛 AssetControllerBase does not use file_url_generator when redirecting Active .

huhhuh → changed the visibility of the branch drupal-3475639 to hidden.

huhhuh → changed the visibility of the branch drupal-3475639 to active.

huhhuh → changed the visibility of the branch drupal-3475639 to hidden.

huhhuh → created an issue.

Actually, this might be a breaking change if someone is using \Drupal\Monolog namespace. 🤔

huhhuh → created an issue.

There was a small typo in #14. Here is fixed patch without tests.

And this should include the file. :)

And this should apply with composer patches. :)

Hi, #11 does not work for us. The preg_replace_callback regex only matches the first line.

Here is my attempt and I added some tests as well.

Patch for Drupal 10.2.

I'm looking at this with a debugger and LanguageNegotiationUserAdmin::isAdminPath calls AccessAwareRouter::match with path "/ckeditor5/upload-image/basic_html". This creates a new Request object that no longer has the original request method. Eventually the MethodFilter throws MethodNotAllowedException, since the route for image upload does not accept GET methods.

Hello,

I encountered this same issue on my site. I can confirm that setting "Administration pages language" to "No preference" seems to fix this.

Here is a repo that can reproduce this issue: https://github.com/hyrsky/drupal-3351241.

I don't think this has anything to do with ckeditor5 and the bug is somewhere else. I believe this is a is a duplicate of #2706241 🐛 AccessAwareRouter does not respect HTTP method Fixed .

I figured out that NPM registry contains the compiled js that can be used!

Forgot to add the patch file:

Hi 👋,

I was looking into math input modules for CKEditor5 and found this. Great work! Here are some fixes/feedback/opinions (especially related CKEditor5):

• - CKEditor5PluginElementsSubsetInterface inherits CKEditor5PluginConfigurableInterface ( https://www.drupal.org/project/drupal/issues/3246012 → )
• > Why not hard code the classname so that the subset code and form code could be removed? Anyway, my patch just adds the the missing methods to make the plugin class work.
• - Error: Class "Drupal\ckeditor\CKEditorPluginBase" not found if ckeditor4 is not installed.
• > Added ‘provider’ definitions: https://drupal.stackexchange.com/questions/299020/how-can-i-let-a-plugin...
• - CKEditor5 plugin id must start with ckeditor5_
• - Fixed few typos
• - I think the form page should always include the library since it contains test markup.
• - mathjax_editor_js_settings_alter: The condition was never true for CKEditor5
• - CKEditorError: plugincollection-soft-required {"missingPlugin":"Autoformat","requiredBy":"AutoformatMath"}
• > I believe AutoformatMath requires: https://www.npmjs.com/package/@ckeditor/ckeditor5-autoformat as a dependency
• > I removed AutoformatMath from CKEditor5Plugin for now to stop the editor from crashing.
• - Something in the js (?) sets the CKEditor generated span element to: <span class=“undefined”>.

I was not able to get this fully working yet, but it is quite close.

Hello!

I have implemented CKEditor 5 support. My fork of the repo is also here:
https://github.com/hyrsky/ckeditor_media_embed

It uses this:
https://ckeditor.com/docs/ckeditor5/latest/features/media-embed.html#demo

I made a short demo video (Twitter embed looks weird on the demo because my adblocker blocked the twitter widget script). The api key shown on the video is no longer valid 😅.
https://streamable.com/6ewg5j

This does does need some cleanup still. I have only commented out all the code related to the AssetManager. I don't really understand how something similar could be supported with CKEditor 5. My solution would be to remove it entirely and just use the webpacked assets like in the current patch. I can post another patch later that removes the AssetManager if there is no better solutions.

Would the maintainers be willing to accept contribution like this to the module? I think it would have to be a new major version. Only the 'Semantic Media Embed' approach is supported.