The next big thing

Hi 👋,

I was looking into math input modules for CKEditor5 and found this. Great work! Here are some fixes/feedback/opinions (especially related CKEditor5):

• - CKEditor5PluginElementsSubsetInterface inherits CKEditor5PluginConfigurableInterface ( https://www.drupal.org/project/drupal/issues/3246012 → )
• > Why not hard code the classname so that the subset code and form code could be removed? Anyway, my patch just adds the the missing methods to make the plugin class work.
• - Error: Class "Drupal\ckeditor\CKEditorPluginBase" not found if ckeditor4 is not installed.
• > Added ‘provider’ definitions: https://drupal.stackexchange.com/questions/299020/how-can-i-let-a-plugin...
• - CKEditor5 plugin id must start with ckeditor5_
• - Fixed few typos
• - I think the form page should always include the library since it contains test markup.
• - mathjax_editor_js_settings_alter: The condition was never true for CKEditor5
• - CKEditorError: plugincollection-soft-required {"missingPlugin":"Autoformat","requiredBy":"AutoformatMath"}
• > I believe AutoformatMath requires: https://www.npmjs.com/package/@ckeditor/ckeditor5-autoformat as a dependency
• > I removed AutoformatMath from CKEditor5Plugin for now to stop the editor from crashing.
• - Something in the js (?) sets the CKEditor generated span element to: <span class=“undefined”>.

I was not able to get this fully working yet, but it is quite close.

Forgot to add the patch file:

Hey, thanks for the feedback, I incorporated most of it into the branch.

> Why not hard code the classname so that the subset code and form code could be removed? Anyway, my patch just adds the the missing methods to make the plugin class work.

Because, as I mentioned in the description, there is an open PR on GitHub which allows to configure the classname of the element. I'm currently working on a project where exactly this is a required thing.

> mathjax_editor_js_settings_alter: The condition was never true for CKEditor5

Yes, because this is how the CKEditor4 plugin works. It is not required for the CKEditor5 plugin.

Hey there,

I've tried out these changes and the interface is working great :)

I did need to make a few small tweaks to CKEditor5Plugin/Mathjax.php though:

• The 'provider' annotation should be up one level, outside of @DrupalAspectsOfCKEditor5Plugin
• There are still some methods missing for CKEditor5PluginElementsSubsetInterface (I just removed the implements)
• I had to remove the call to 'getElements' on line 89 (getPluginDefinition was returning an array directly)

Thanks for the great work! Added defer to the plugin in libraries as the editor can error with

Uncaught TypeError: can't access property "config", settings.mathjax is undefined
CKEditorError: plugincollection-plugin-not-found {"plugin":null}

when JS aggregation is set $config['system.performance']['js']['preprocess'] = TRUE.