I want to point out, you dropped the whole API documentation from my initial commit, without any replacement. I'd love to have some information about the Event approach in the README instead, so I will know it is possible at all.
In this approach I see e big flaw ... all properties of the SpanBulder are private ... so I got no clue if I have to rely on an attribute to be present. May be I am missing something, as I am not that deep into the SDK, yet.
Well ... Sahana_N updated the wrong info.yml ... this ticket should be reopened.
opentelemetry.info.yml -> opentelemetry_logs.info.yml
Daniel Kulbe → created an issue.
Daniel Kulbe → created an issue.
I also find this very expensive iterating the whole list, if only one job is already known to be "empty".
(For reference, the Error thrown by Redis in this case is "WRONGTYPE Operation against a key holding the wrong kind of value")
When we try to claim the item, we already know the ID, which is empty. So only this one should be removed at this point.
So I am adding my solution here, asking for review.
Re-roll against 6.0.x
Re-roll against 6.0.x
Hey, thanks for the feedback, I incorporated most of it into the branch.
> Why not hard code the classname so that the subset code and form code could be removed? Anyway, my patch just adds the the missing methods to make the plugin class work.
Because, as I mentioned in the description, there is an open PR on GitHub which allows to configure the classname of the element. I'm currently working on a project where exactly this is a required thing.
> mathjax_editor_js_settings_alter: The condition was never true for CKEditor5
Yes, because this is how the CKEditor4 plugin works. It is not required for the CKEditor5 plugin.
Re-upload
Updated patch for 9.5.x
Daniel Kulbe → created an issue.
Works fine for me.
If you are interrested in one step beyond CKEditor 4 support, you can give #3339936 ✨ The next big thing Needs work a try.
One step beyond (#3339936) ✨ The next big thing Needs work ... just a suggestion.
Daniel Kulbe → created an issue.
Tiny last thing I saw - the last line is missing the full stop.
There's a typo in Line 1 "LATAX" should be "LATEX".
Daniel Kulbe → created an issue.
Just fixing a tiny formatting issue with this update, no functional issues
The issue is, you will see the role access checkboxes, event the check is never performed for any menu item with an internal route, unless you have configured to overwrite the default access check, as mentioned in #4. This might be confusing for the most.
I try to present you a solution which respects the default menu item access check and instead applies the role access check on top of it, when configured. Let me know, if this works for you as well.
@maximpodorov, you are right, could really drop it entirely, according to this article:
https://www.filamentgroup.com/lab/load-css-simpler/
... even for the fact, the project is now archived and no longer maintained.
Issue summay updated.
One final thought on this - the original code is right in one further thing: The Condition should be added to the conditions array in every case, even if there is an exception, so when collecting cachability, every condition is applied to forbidden for missing value, not just only the valid ones. Adding another version here, which fixes this.
Sorry, still found a tiny JavaScript selector issue. I will not start the failed tests in 78 again, as nothing has changed.
Can please sb. take care of the functional test, who has some strong suites there.
Please also note, I fixed in this Version :
- Missing context vs. context value, a cache issue, as stated in the comment in code.
- The conditions count was created prior the and-or plugin was removed.
- The form
- I applied the same logic in the radio negate switch form to all considerable elements in the form.
- I choose to stick to jQuery in block.js
One further opinion on this ... the check regarding the empty request_path plugin - shouldn't it be happen in the plugin form validation method instead. It is called a few lines below where the check was added.