Hi Lucas,
Sorry if this was unclear!
This MR is not trying to solve that CI issue - the only change here is updating the template inline docs to match what's upstream.
The current template contains links & docs which have been superceded or deprecated.
It's not a big change, and from the MR you can see there's no functional change (only changes to lines starting with a comment).
I will put this back to "needs review", but there's no urgency on this, since it's only DX/docs really :)
FWIW, Renovate can extract release changelogs from projects hosted on gitlab.com. Here's a screenshot of this happening from a Renovate PR.
I'm not sure whether this improves the situation (I think it'll depend how Renovate does that, since Drupal does not yet use Gitlab's Releases AFAIK).
I wonder whether Renovate would behave differently if it detected "gitlab" in the package's info/URL (composer.json fixture, test assertions extract gitlab host), but I don't know yet how Renovate gets from package information to extract changelog data.
CI failure is due to 📌 pipeline failure - composer (previous minor) Active / 📌 Security blocks on Twig versions for Drupal 9 Active , not this PR. Passing test run (with "previous minor" not enabled) can be seen at https://git.drupalcode.org/project/migrate_plus/-/merge_requests/148/pip...
AI module made https://git.drupalcode.org/project/ai/-/commit/fabcfac27043b0918dd030d63649a20a325d79e8">this change to address this, in case it's of interest.
Another fix would be to not opt in to previous minor testing, which was introduced recently in https://git.drupalcode.org/project/ai/-/commit/d7d3c692">d7d3c692 for 📌 Annotation to PHP Attributes conversion Active .
Marking closed won'tfix for now, it's fine to re-open this if we should do something here. I see that @heddn has noticed this also, per https://git.drupalcode.org/project/gitlab_templates/-/merge_requests/442...
Looks like the "composer (previous minor)" issue is related to 📌 pipeline failure - composer (previous minor) Active and can be disregarded here.
Tested with an existing JSONPath migration locally, dataparser goes away when softcreatr/jsonpath is not a dependency of the current project, is available and works when it is. Further testing welcome!
xurizaemon → created an issue.
Add details for Aotearoa New Zealand
Updating ID so that list of retained destinations is clearer. Seems reasonable to drop shortcut_set_users, d7_theme_settings, user_data.
I think the entity destinations should be retained, Migrate is such a good general purpose toolkit I expect there are integrations using many of those.
Unsure if anyone might be destinating data to all of them, eg entity:image_style, but there's a scenario for almost everything!
xurizaemon → made their first commit to this issue’s fork.
Opened 🐛 Invalid schema for unexpected JSON (text) field size 16384 Active with related issue and fix I observed upgrading from 8.x-1.4 to 8.x-1.7.
For the site I saw this behaviour on, it also appears to have worked to apply a workaround of manually updating the field size in field.storage.*.*.*.yml to set setting.size = 65536 where type = "json" and setting.size = 16384. This allowed the CI pipeline to successfully execute a drush site-install --existing-config, and for me appears to have allowed a copy of live data to upgrade via json_field_post_update_fix_field_size().
Remove duplicated text re unsolicited dms
Added guidance against unsolicited DMs
xurizaemon → changed the visibility of the branch 8.x-1.x to hidden.
xurizaemon → made their first commit to this issue’s fork.
Yeah, this had confused me in the past too; especially if your PHP makes both `memcache` and `memcached` extensions available, you'll see two versions in the status report with no additional context, which might lead to the understandable interpretation that client and server are both shown there. Instead, the user is being shown two versions.
We can do what's proposed in the issue currently - add additional text (as shown in screenshot above) to indicate that this is the version of the extension. It would be nice to also add the server version to the status page, but no need for this issue to wait on that.
Test reports failure on PHPUnit run, but it does not look related to the code changes in this MR.
xurizaemon → made their first commit to this issue’s fork.
I observed this on a site, and found my way to this issue.
On the affected site, the return value of $route_name = \Drupal::routeMatch()->getRouteName(); on the 404 page was NULL when this happened.
Cross-checking on a different site, I saw that the route on a 404 page is system.404.
I observed that on the affected site, the stack trace originated from BigPipe. When BigPipe module was disabled on the affected site, I was unable to reproduce the issue.
OK, MR created, seems to work but I don't use this module myself so review / testing welcome.
xurizaemon → created an issue.
@willp24 it looks like the Migrate Orphans code on that site requires a change to account for the change in this module.
The change required is documented at https://www.drupal.org/node/3537201 →
This will require an issue in the Migrate Orphans project.
Oh no, Gitlab ratted me out! The "throwaway" MR on that issue repo can be ignored; I was using a recent issue as a test to identify where we tag the previous Git state on force push. Those last few updates from me (after the issue was fixed) are bogus and can be ignored :)
xurizaemon → made their first commit to this issue’s fork.
Ran into this myself, for me it reproduces when executing any migration that has data_parser=xml.
@heddn I think there is existing coverage for this, eg tests/src/Kernel/Plugin/migrate_plus/data_parser/XmlTest.php?
Testing locally, 6.0.x @ 46d05c256
www-data@da85fa35e6fa:/app$ phpunit -c /app/phpunit.xml web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/XmlTest.php
PHPUnit 9.6.23 by Sebastian Bergmann and contributors.
Testing Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser\XmlTest
SEEEEEEE 8 / 8 (100%)
Time: 00:09.863, Memory: 10.00 MB
There were 7 errors:
1) Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser\XmlTest::testCurrentUrl
TypeError: Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Xml::__construct(): Argument #4 ($file_system) must be of type Drupal\Core\File\FileSystemInterface, Drupal\migrate_plus\DataFetcherPluginManager given, called in /app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php on line 147
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:105
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:147
/app/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php:21
/app/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php:83
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:272
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:93
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
2) Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser\XmlTest::testReduceSingleValue
TypeError: Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Xml::__construct(): Argument #4 ($file_system) must be of type Drupal\Core\File\FileSystemInterface, Drupal\migrate_plus\DataFetcherPluginManager given, called in /app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php on line 147
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:105
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:147
/app/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php:21
/app/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php:83
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:272
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:112
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
3) Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser\XmlTest::testSingleValueWithAttributes
TypeError: Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Xml::__construct(): Argument #4 ($file_system) must be of type Drupal\Core\File\FileSystemInterface, Drupal\migrate_plus\DataFetcherPluginManager given, called in /app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php on line 147
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:105
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:147
/app/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php:21
/app/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php:83
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:272
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:138
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
4) Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser\XmlTest::testMultipleItems
TypeError: Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Xml::__construct(): Argument #4 ($file_system) must be of type Drupal\Core\File\FileSystemInterface, Drupal\migrate_plus\DataFetcherPluginManager given, called in /app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php on line 147
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:105
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:147
/app/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php:21
/app/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php:83
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:272
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:171
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
5) Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser\XmlTest::testPredicateMatch with data set "odd parity" ('/items/item[@parity="odd"]', array(array('Value 1'), array('Value 3')))
TypeError: Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Xml::__construct(): Argument #4 ($file_system) must be of type Drupal\Core\File\FileSystemInterface, Drupal\migrate_plus\DataFetcherPluginManager given, called in /app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php on line 147
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:105
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:147
/app/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php:21
/app/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php:83
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:272
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:206
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
6) Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser\XmlTest::testPredicateMatch with data set "even parity" ('/items/item[@parity="even"]', array(array('Value 2')))
TypeError: Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Xml::__construct(): Argument #4 ($file_system) must be of type Drupal\Core\File\FileSystemInterface, Drupal\migrate_plus\DataFetcherPluginManager given, called in /app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php on line 147
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:105
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:147
/app/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php:21
/app/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php:83
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:272
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:206
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
7) Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser\XmlTest::testPredicateMatch with data set "special attribute" ('/items/item[condition[@specia...rue"]]', array(array('Special value')))
TypeError: Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Xml::__construct(): Argument #4 ($file_system) must be of type Drupal\Core\File\FileSystemInterface, Drupal\migrate_plus\DataFetcherPluginManager given, called in /app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php on line 147
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:105
/app/web/modules/contrib/migrate_plus/src/Plugin/migrate_plus/data_parser/Xml.php:147
/app/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php:21
/app/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php:83
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:272
/app/web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/BaseXml.php:206
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
ERRORS!
Tests: 8, Assertions: 0, Errors: 7, Skipped: 1.
With !133 @ a9f469bf
www-data@da85fa35e6fa:/app$ phpunit -c /app/phpunit.xml web/modules/contrib/migrate_plus/tests/src/Kernel/Plugin/migrate_plus/data_parser/XmlTest.php
PHPUnit 9.6.23 by Sebastian Bergmann and contributors.
Testing Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser\XmlTest
S....... 8 / 8 (100%)
Time: 00:09.940, Memory: 10.00 MB
OK, but incomplete, skipped, or risky tests!
Tests: 8, Assertions: 10, Skipped: 1.
Unsilenced deprecation notices (7)
7x: Creation of dynamic property Drupal\migrate_plus\Plugin\migrate_plus\data_parser\Xml::$fileSystem is deprecated
3x in XmlTest::testPredicateMatch from Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser
1x in XmlTest::testCurrentUrl from Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser
1x in XmlTest::testReduceSingleValue from Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser
1x in XmlTest::testSingleValueWithAttributes from Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser
1x in XmlTest::testMultipleItems from Drupal\Tests\migrate_plus\Kernel\Plugin\migrate_plus\data_parser
Confirmed, MR resolves recently introduced fatal error when using this module on PHP 8.1. Appreciate the patch!
xurizaemon → made their first commit to this issue’s fork.
xurizaemon → created an issue.
Patch fixes the issue.
xurizaemon → made their first commit to this issue’s fork.
xurizaemon → created an issue.
Good point Michael. I feel I'm confused now from juggling changes (and git is giving me weird results / not showing changes from upstream?), so I'm going to leave this for tonight. Thanks!
Following up on my own question re branch for 6.1.x - FYI @heddn, the 6.1.0 and 6.1.1 releases are from the 6.0.x branch.
(Not meaning to nitpick, just alerting to something which was confusing me when I tried git operations relating to that branch.)
I believe this change also caused breakage on sites using Migrate Source UI, as the 6.0.x function signature is used there. Opened 🐛 Migrate Tools v6.1.x compatibility Active .
Quick workaround can be to downgrade to 6.0.x for sites using Migrate Source UI? That worked for 6.0.5 for me.
I see this MR (and issue) currently targets 6.0.x, but introduces a deprecation notice and fixes handling for 6.1.x - should the MR be targeting 6.1.x or 6.0.x?
Suggest that we update "Proposed resolution" so that the intent of this change is clearer?
Thanks for working on this!
xurizaemon → created an issue.
Linking 🐛 New parameters introduced in MigrateExecutable class constructor Active (likely intended link for last comment)
It was a dupe of 🐛 Declare PHP requirement >= 7.4 Closed: outdated anyway :)
Closing as a duplicate of 📌 Automated Drupal 11 compatibility fixes for jsonlog Active because the other has RTBC already
xurizaemon → created an issue.
Quick MR (for today) is a start point, not considered a finished solution :)
I expect tracing is a performance critical path, so we don't want to add too much code anyway?
Interested to hear thoughts!
xurizaemon → created an issue.
removing assignment from 2019
We observed issue with PDFs embedded on the "main" (www.example.org) URL when viewed from an admin-specific URL (eg admin.example.org, if you were viewing from a separate admin URL for use cases such as CloudFlare). The error message displayed was "Message: file origin does not match viewer's". I've added this to the issue description as Case 2.
Patch 10 from 🐛 Behind HTTPS Load Balancer, Renders HTTP load of JS to Browser Needs work makes the viewer JS a relative URL, removing the hostname. For some folks running into this issue, that may be enough to solve the display problem.
However, it seems like that patch won't address Case 1 in this issue description (remote PDF, via remote stream wrapper, on a different host to the viewed page).
Is this related to 🐛 Render using theme input and select instead of lists with links for checkboxes and dropdown Needs review changes?
The above comment was made via MR !297, and when viewed on the MR shows more context - that the specific change is the removal of the secondary selector , .js-facets-links from line 19 of js/checkbox-widget.js.
Rebased
Improved positioning at least via https://git.drupalcode.org/project/migrate_visualize/-/merge_requests/17
xurizaemon → created an issue.
The change record didn't clearly communicate the required fix here for me, and I overthought it.
Solution (I now believe!) is to add langcode: en to the default configuration yaml files in the module's config/install folder.
benjifisher → credited xurizaemon → .
xurizaemon → created an issue.
I haven't forgotten about this! I've been making some progress over on 📌 Connect pseudofield sources to use in pipeline Active which is adjacent.
I think if we pull the BPMN JS libraries in directly (as is done for Mermaid currently), we can then output the diagram in BPMN notation, and I don't expect that to take much refactor as we are adding a third output format (GraphViz, Mermaid, BPMN) to an implementation which currently delivers two.
I expect this would trigger renaming the `migrate_visualize/js` JS to `migrate_visualize/mermaid` and adding a similar JS to initialize BPMN.
That solves the "what might ECK / BPMN do" issue. If such an integration module for BPMN does appear, we can always switch to that later. For now, CDN inclusion is fine by me; this is a dev module.