Establish automated test coverage for Flysystem

It would be great if this can happen as part of 🌱 Planning for Release 3.0.0, Drupal 10.3+ Compatibility, Flysystem v3.1 Compatibility Needs work , setting that as parent issue.

@xurizaemon: Thank you for the .gitlab-ci.yml file, I had not had time to track that down in the Drupal documentation to get tests running on the Gitlab CI pipeline again.

See my comments regarding the removal of the Asset classes from Flysystem, those were implemented to allow writing CSS and JS assets to a remote stream wrapper as part of a Flysystem schema implementation. With the introduction of the "asset://" scheme in Drupal core for CS/JS asset management, the can now be overridden with a normal scheme definition for Flysystem, just as you can override the "public://" and "private://" schemes.

Thank you for jumping in on this!

Current status is that https://git.drupalcode.org/project/flysystem/-/pipelines/393131 is passing, but not green (fails on: cspell, eslint, phpstan).

I'm happy to progress that to green if you want @lhridley?

@xurizaemon -- if you can fix the linting and cspell checks please do so; however the phpstan issues are related to some functional bugs that I introduced when in pulled in the Twistor/FlysystemStreamWrapper code into the project and refactored it to remove all of the unnecessary static calls. I am tracking those issues down now, no need for both of us to work on the same thing.

Perfect, thanks! I will sort out cspell and linter job failures in this issue.

@xurizaemon I've also got tests working on the 2.2.x branch, those were pushed up earlier today. I'm using this as a baseline for the 2.3.x refactor that is currently not working.

The following test coverage does not exist for the 2.2.x or 2.3.x branches, listed in priority order:

* https://www.drupal.org/project/flysystem/issues/3499242 📌 Create a Functional test for replacing Drupal Core's "assets://" stream wrapper with a Flysystem implementation. Active (highest priority, can be implemented for 2.2.x or 2.3.x branch)
* https://www.drupal.org/project/flysystem/issues/3497811 📌 Add test coverage for Drupal\flysystem\Form\FieldMigration Active (exists on the 2.3.x branch only)

I really want to have the first set of tests covering using a Flysystem adapter to replace Drupal Core's assets stream wrapper written and working before embarking on the D11 compatibility, as well as picking back up the 3.0.x refactor to implement League/Flysystem v3 Library.

But, that is a significant body of work, so for expediency I was going to plan on implementing D11 compatibility with League/Flysystem v1 in 2.3.x, and save upgrading to League/Flysystem v3 for a 3.0.x release.

If you'd like to jump in on the functional tests for replacing the Core "assets" stream wrapper with a Flysystem Stream Wrapper (the Local adapter is included in the Drupal Flysystem main module) that would be super awesome.

xurizaemon → closed merge request !74

xurizaemon → closed merge request !75

@lhridley, fixes for cspell and eslint are in https://git.drupalcode.org/project/flysystem/-/merge_requests/84 now

lhridley → closed merge request !84