- Issue created by @Coop920
- First commit to issue fork.
- @orbmantell opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:45pm 24 August 2023 - πΊπΈUnited States orbmantell
Added a MR for adding a CKEditor 5 plugin
- π¨π¦Canada alxp Charlottetown, PE
Hi, thank you fro the MR, I don't actively use this module anymore so it will be a bit of work to spin up a site to test your MR but I'll try to get to it this weekend.
Appreciate the effort!
- π¨π¦Canada alxp Charlottetown, PE
@orbmantell I checked out the MR to test and am experiencing a couple of problems:
1. The .info.yml file still requires CKEditor 4. I don't know what the normal procedure is for supporting both, but I am open to a new major version for CKEditor 5 support.
2. When I place the button in the active toolbar, Drupal shows this error:
"The CKEditor Block Quote Attribution plugin needs another plugin to create , for it to be able to create the following attributes: . Enable a plugin that supports creating this tag. If none exists, you can configure the Source Editing plugin to support it."Is there an existing CKEditor plugin for 'figure' we can just declare a dependency on? There are no helpful google results for this error message.
A more general question, the MR includes the yarn lock file. Is there any reason I would need to include this, or should it be .gitignored?
Thanks for your work on this, I look forward to including it. Unfortunately CKEditor 5 is too big a change for me to dive in at the moment.
I'd be open to adding a co-maintainer if you are interested.
- Status changed to Needs work
over 1 year ago 9:51pm 2 September 2023 - First commit to issue fork.
- πΊπΈUnited States jayhuskins
I created this separate branch for work on a 3.x branch of this module that removes CKEditor4 dependencies
https://git.drupalcode.org/issue/ckeditor_blockquote_attribution-3362519... - Status changed to Needs review
9 months ago 5:13pm 15 March 2024 - πΊπΈUnited States jayhuskins
The `CKEditor5 - 3.x` branch is ready to be added as a 3.x version.
- π¨π³China skyredwang Shanghai
skyredwang β changed the visibility of the branch 3362519-ckeditor-5-support to hidden.
- π¨π³China skyredwang Shanghai
skyredwang β changed the visibility of the branch 8.x-2.x to hidden.
- π¨π³China skyredwang Shanghai
After learning the details of the feature of the plugin, I decided to not forward to porting it to CKEditor5. Below are my thoughts:
- There are two types of attributions. The first one is the address/url of the source. We should use the
cite
attribute in the<blockquote>
, however, this attribute doesn't render for the end user. The second one is a name or small title of the source. We should use the<cite>
tag inside the<figcaption>
. The current module doesn't implement either.Specification comes from https://developer.mozilla.org/en-US/docs/Web/HTML/Element/cite
- Currently, the feature is implemented in Drupal. The limitation is that the attribution created this way won't be editable. In other words, a user cannot edit an existing blockquote attribution in the content, they can only delete and recreate. This is because Drupal does not need to process, render, understand or otherwise interact with it.
If there is still interest in this feature, I think it should be implemented as a CKEditor5 plugin (Not a Drupal CkEditor 5 module plugin), then Drupal simply calls to use it.
- π¨π³China skyredwang Shanghai
skyredwang β changed the visibility of the branch 3362519-ckeditor5-port to hidden.