Hello, thank you for the offer to co-maintain. I have been travelling os did not get to this until this week, so apologizes for the delay.
I've made you a co-maintainer with privileges to edit releases and issues and push to VCS.
Have a great week and feel free to reach out to collaborate on future changes.
@orbmantell I checked out the MR to test and am experiencing a couple of problems:
1. The .info.yml file still requires CKEditor 4. I don't know what the normal procedure is for supporting both, but I am open to a new major version for CKEditor 5 support.
2. When I place the button in the active toolbar, Drupal shows this error:
"The CKEditor Block Quote Attribution plugin needs another plugin to create , for it to be able to create the following attributes: . Enable a plugin that supports creating this tag. If none exists, you can configure the Source Editing plugin to support it."
Is there an existing CKEditor plugin for 'figure' we can just declare a dependency on? There are no helpful google results for this error message.
A more general question, the MR includes the yarn lock file. Is there any reason I would need to include this, or should it be .gitignored?
Thanks for your work on this, I look forward to including it. Unfortunately CKEditor 5 is too big a change for me to dive in at the moment.
I'd be open to adding a co-maintainer if you are interested.
Hi, thank you fro the MR, I don't actively use this module anymore so it will be a bit of work to spin up a site to test your MR but I'll try to get to it this weekend.
Appreciate the effort!
This patch works and makes sense to me. Sorry for the delay, I don't use this module at my current workplace and had to set up my dev environment.