πŸ‡ΊπŸ‡ΈUnited States @orbmantell

Account created on 18 June 2010, over 14 years ago
  • Technical Architect at GenuineΒ  …
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States orbmantell

This patch in #16 has issues with multilingual sites. When editing a translated node there are no paragraphs allowed to be added, so the $types_available variable in paragraphs_ee_field_widget_complete_form_alter() is empty. This causes an issue with $render_order = array_combine(array_keys($types_available), range(0, count($types_available) - 1));, as it tries to call array_combine() on an empty array and an array with two elements (0 and -1). This throws a ValueError due to mismatching numbers of keys and values.

πŸ‡ΊπŸ‡ΈUnited States orbmantell

orbmantell β†’ changed the visibility of the branch 3487078-php-deprecation-warning to hidden.

πŸ‡ΊπŸ‡ΈUnited States orbmantell

I came across this issue, and the changes here (mostly) resolved the issue I was having (drush not being able to import profile-based splits)

The issue is mostly resolved because the referenced branch here is behind 2.x (https://git.drupalcode.org/project/profile_split_enable/-/compare/326217...). I created a patch locally to merge these changes, but was unable to get the test_dependencies change to apply cleanly. When I removed that change the patch applied and my issue was resolved.

If the changes in this ticket incorporate the latest changes from 2.x and the test_dependencies change is able to apply cleanly my vote is to get this merged. I am leaving this ticket as needs review since there is no patch that applies cleanly, but from a "the change fixes the issue" standpoint I would say this is RTBC.

πŸ‡ΊπŸ‡ΈUnited States orbmantell

Attaching patch

πŸ‡ΊπŸ‡ΈUnited States orbmantell

Added a MR for adding a CKEditor 5 plugin

πŸ‡ΊπŸ‡ΈUnited States orbmantell

orbmantell β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States orbmantell

Attaching patch which should fix the issue.

Production build 0.71.5 2024