- Issue created by @pietermouton
- Status changed to Needs review
about 1 year ago 11:06am 1 April 2024 - ๐ฎ๐ณIndia abhishek_virasat
@pietermouton , I have fixed the issue please review the patch file.
-
generalredneck โ
committed c1d72044 on 8.x-1.x
Issue #3435937 by abhishek_gupta1, pietermouton, generalredneck: PHP 8.2...
-
generalredneck โ
committed c1d72044 on 8.x-1.x
- Status changed to Fixed
10 months ago 3:36am 31 May 2024 - Status changed to Needs work
10 months ago 8:52am 13 June 2024 - ๐ง๐ชBelgium pietermouton
Seems like there was a small issue with the patch;
$form_state->dependent_exposed_filters[] = $dependency_info; is still in the source-code (line 330) and can be removed.
$form_state->dependent_exposed_filters also needs to be replaced with $form_state->get('dependent_exposed_filters') on line 41 of the views_dependent_filters.module file.
- First commit to issue fork.
- Status changed to Needs review
10 months ago 11:35am 13 June 2024 - Status changed to RTBC
3 months ago 7:25am 25 December 2024 - ๐น๐ทTurkey orkut murat yฤฑlmaz Istanbul
I've tested @immaculatexavier's MR as a patch and it works.
Thanks for contributions.
- ๐ฎ๐ณIndia vandanasom.123
vandanasom.123 โ made their first commit to this issueโs fork.
- ๐น๐ทTurkey orkut murat yฤฑlmaz Istanbul
@vandana, there is a conflict in your MR. can you resolve it and then update your MR please?
- ๐ฎ๐ณIndia mugesh.s Tamil Nadu
I've tested @vandana's MR as a patch and it works.
- ๐ฎ๐ณIndia abhijith_krishna
MR conflicts in phpcs and composer-lint is fixed and the pipeline is clear.
I have tested @vandana's MR as a patch and it is ready for merge. - ๐น๐ทTurkey orkut murat yฤฑlmaz Istanbul
@generalredneck, any chance for merge?
- ๐บ๐ธUnited States orbmantell
I was unable to get MR10 to merge cleanly, so I re-built the patch.
- ๐ฎ๐ณIndia vandanasom.123
@orbmantell, thank you for the patch. However, I encountered the following error:
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2025-02-27/views_dependent_filters-3... โ
Please try the patch provided:
-
generalredneck โ
committed 56e4a2de on 8.x-1.x authored by
immaculatexavier โ
Issue #3435937 by generalredneck, pietermouton, abhishek_gupta1: PHP 8.2...
-
generalredneck โ
committed 56e4a2de on 8.x-1.x authored by
immaculatexavier โ
- ๐บ๐ธUnited States generalredneck Texas, USA ๐บ๐ธ
All I did was change the license that was added to composer.json given it was incorrect and used the one that is added by drupal's packagist magic.
Given that, since this issue was marked as RTBC before some support related issues from #19 on, I'm going to push this and get a new release out.
- ๐บ๐ธUnited States generalredneck Texas, USA ๐บ๐ธ
In the future please let the automation system move issues to "closed fixed" as per issue best practices
- ๐บ๐ธUnited States generalredneck Texas, USA ๐บ๐ธ
Adding credit for vandanasom.123 as for some reason it didn't get added automatically even though they made the MR.... Wierd