- Issue created by @wim leers
- Merge request !8359Resolve #3453659 "Configentityvalidationtestbasetestrequiredpropertyvaluesmissings assumptions prevent" β (Open) created by wim leers
- Status changed to Needs review
5 months ago 12:08pm 10 June 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
β¦ or β¦ on second thought β¦ should we flip that around, and is this not a bug in this test, but in the config entity infrastructure, where every config entity type MUST allow
NULL
to be set on any class property corresponding to a top-level config entity property, precisely to avoid triggering fatal PHP errors for something as innocent as:$format = FilterFormat::load('basic_html'); $format->set('settings', NULL);
- π¬π§United Kingdom f.mazeikis Brighton
Wim Leers β credited f.mazeikis β .
- πΊπΈUnited States mtift Minnesota, USA
So if "every config entity type MUST allow NULL to be set on any class property corresponding to a top-level config entity property" would the implication be that:
protected array $settings = [];
Gets interpreted as:
protected array|null $settings = [];
That seems confusing to me.
- Status changed to Needs work
5 months ago 5:24pm 17 June 2024 - πΊπΈUnited States smustgrave
Change appears to have caused a test failure.
- πΊπΈUnited States mtift Minnesota, USA
I'm pretty sure the intention of the change (with the commit message "Example") was to demonstrate a test failure.
- π³πΏNew Zealand quietone
Fixes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.