- πΊπΈUnited States mherchel Gainesville, FL, US
OK. Just pushed final fixes. This should be good to go. Note I refactored the CSS and markup significantly, so setting to NR.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Last commit was "WIP on testimonials.", meaning Work in Progress.
Moving back to Needs work.
- πΊπΈUnited States phenaproxima Massachusetts
I would vote we remove it for now and fix it in a follow-up.
- πΊπΈUnited States bernardm28 Tennessee
The image is commented out because it creates an error with experience builder. Commenting that section out removes said error and the props load from within experience builder. if that issue is solved we can bring it back.
- πΊπΈUnited States phenaproxima Massachusetts
How to test, now that π Add Experience Builder to dev dependencies Active is in:
- Check out this branch locally
- Pull changes from 1.x and merge them into this branch
-
ddev rebuild ddev drush si -y ddev drush recipe ../xb_test ddev launch /xb/xb_page/1
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 1.x. Hope this helps contributors!
-
phenaproxima β
committed 80b7d65b on 1.x
Issue #3507902 by phenaproxima: Add Experience Builder to dev...
-
phenaproxima β
committed 80b7d65b on 1.x
- @phenaproxima opened merge request.
- Issue created by @phenaproxima
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
@bernardm28 Why was the image commented out?
- πΊπΈUnited States phenaproxima Massachusetts
Finally merged into 1.x, thanks!
-
phenaproxima β
committed b5d372c7 on 1.x authored by
boulaffasae β
Issue #3497387 by kristen pol, boulaffasae, vasantha deepika, pameeela,...
-
phenaproxima β
committed b5d372c7 on 1.x authored by
boulaffasae β
- πΊπΈUnited States phenaproxima Massachusetts
Alright, folks seem to agree this looks good and I can find nothing to complain about in the code. Sick of seeing this one languish in review forever, so I'm merging it.
- π¦πΊAustralia pameeela
This is looking great based on the screenshots! Don't wait for my review, happy for a front end tick to get this merged.
- πΊπΈUnited States bernardm28 Tennessee
It seems to be working as expected though I could not add an image on experience builder. But that might be just related to that.
- πΊπΈUnited States mherchel Gainesville, FL, US
This will be a great one to work on at this weekend's Florida DrupalCamp.
- πΊπΈUnited States mherchel Gainesville, FL, US
Just left a review with a number of changes! Thank you!