@lauriii reported over at
🐛
Enabling XB for managing page template breaks Olivero header
Active
that once you use Experience Builder's page template functionality, its (magnificent! 🤩 — love it on my own site 😄) menu functionality breaks down from
to this sad thing:
😭
My digging at #3505629-2: [upstream] Olivero's header works only correctly when using the "block" page variant → surfaced
const searchWideButtonSelector =
'[data-drupal-selector="block-search-wide-button"]';
const searchWideButton = document.querySelector(searchWideButtonSelector);
const searchWideWrapperSelector =
'[data-drupal-selector="block-search-wide-wrapper"]';
const searchWideWrapper = document.querySelector(searchWideWrapperSelector);
— core/themes/olivero/js/search.js
which is targeting markup literally only available in core/themes/olivero/templates/block/block--secondary-menu--plugin-id--search-form-block.html.twig 😅
And that Twig template is specifically targeting a Block config entity in the secondary_menu region with using the search_form_block plugin ID.
CONTRIBUTING.md./admin/appearance/settings/olivero and check the checkbox.Make this Olivero functionality work without assuming markup generated by either BlockPageVariant, BlockViewBuilder or block.html.twig.
Olivero is heavily tightly coupled with the Block module. 😱
TBD
None.
None.
None.
None.
Olivero no longer assumes it will be used with the Block module.
Active
11.1 🔥
Olivero theme
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .
This will be a great one to work on at this weekend's Florida DrupalCamp.