Add validation constraints to comment.type.*

./vendor/bin/drush config:inspect --filter-keys=comment.type.comment --detail --list-constraints --fields=key,validatability,constraints > 🤖 Analyzing… ------------------------------------------------- ------------- ---------------------------------------------------------------------- Key Validatable Validation constraints ------------------------------------------------- ------------- ---------------------------------------------------------------------- comment.type.comment 91% ValidKeys: '<infer>' comment.type.comment: Validatable ValidKeys: '<infer>' comment.type.comment:_core Validatable ValidKeys: - default_config_hash comment.type.comment:_core.default_config_hash Validatable NotNull: { } Regex: '/^[a-zA-Z0-9\-_]+$/' Length: 43 ↣ PrimitiveType: { } comment.type.comment:dependencies Validatable ValidKeys: '<infer>' comment.type.comment:description Validatable Regex: pattern: '/([^\PC\x09\x0a\x0d])/u' match: false message: 'Text is not allowed to contain control characters, only visible characters.' ↣ PrimitiveType: { } comment.type.comment:id Validatable Regex: pattern: '/^[a-z0-9_]+$/' message: 'The %value machine name is not valid.' Length: max: 166 ↣ PrimitiveType: { } comment.type.comment:label Validatable Regex: pattern: '/([^\PC])/u' match: false message: 'Labels are not allowed to span multiple lines or contain control characters.' NotBlank: { } ↣ PrimitiveType: { } comment.type.comment:langcode Validatable NotNull: { } Choice: callback: 'Drupal\Core\TypedData\Plugin\DataType\LanguageReference::getAllVali dLangcodes' ↣ PrimitiveType: { } comment.type.comment:status Validatable ↣ PrimitiveType: { } comment.type.comment:target_entity_type_id NOT ⚠️ @todo Add validation constraints to config entity type: comment.type.* comment.type.comment:uuid Validatable Uuid: { } ↣ PrimitiveType: { } ------------------------------------------------- ------------- ----------------------------------------------------------------------

Comments & Activities

Issue created by @mtift
Comment 8 months ago →
🇺🇸United States mtift Minnesota, USA
First commit to issue fork.
Issue was unassigned.
Comment 8 months ago →
🇺🇸United States mtift Minnesota, USA
Comment 8 months ago →
🇧🇪Belgium borisson_ Mechelen, 🇧🇪
This requires us to add something like EntityTypeExistsValidator, currently working on that.
Merge request !8568Add new validation constraint, configure it on comment schema → (Open) created by borisson_
Pipeline finished with Failed
8 months ago
Total: 190s
#210425
Pipeline finished with Failed
8 months ago
Total: 606s
#210440
Pipeline finished with Failed
8 months ago
Total: 167s
#210752
Comment 8 months ago →
🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Spellcheck fails, but not sure how to better name this.
Status changed to Needs review 8 months ago12:45pm 28 June 2024
Comment 8 months ago →
🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Status changed to Needs work 8 months ago3:53pm 28 June 2024
Comment 8 months ago →
🇺🇸United States smustgrave
MR appears to have phpcs errors.
Comment 8 months ago →
pooja_sharma
I have observed the test failures, may be we can use:

"commentAccepted/commentEligible/commentAllowed" in place of "Commentable"

As "commentAccepted/commentEligible/commentAllowed" word would be more closer/relative to the "Commentable" word to fix cspell test failures.

Left suggestion not updating MR, as most of the work done already.

Add validation constraints to comment.type.*

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!8568Add validation constraints to comment.type.*
Open

Comments & Activities

Add validation constraints to comment.type.*

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!8568Add validation constraints to comment.type.*Open

Comments & Activities

!8568Add validation constraints to comment.type.*
Open