Add validation constraints to contact.form.*

😬 Forgot to change status while cloning

#2: Hah! :D

This is a good start, but there's a bunch left to do.

I see no reason to allow weight to be nullable

Left review on MR - we can add proper types with deprecation message as 11.x going beta

I tried to add deprecation message in previous commit, not sure if this is the correct way or not. But due to this change tests started failing. https://git.drupalcode.org/issue/drupal-3445976/-/jobs/1632410#L2068

The MR looks good, I think it just needs a CR for the deprecation. RTBC'd otherwise 👍🏼

Moved to NW for fixing deprecation errors in better way

I attempted to remove the @legacy from the tests, which I added in previous commit, but it seems something was done incorrectly in the MR, resulting in deprecation errors. I would appreciate any assistance.

I noticed a few more things but this is looking very close to ready. It does still need a change record.

This one makes sense to me. All of the reply & redirect issues have been addressed per https://www.drupal.org/node/3452650 → . The deprecation messages and tests make sense. The feedback has been addressed.

However, I applied the MR on a standard install for 11.x with config inspector and got all green checks, but it shows "1 errors" and I'm not quite sure what that is referring to:

I know nothing about config inspector, but I assume that it's flagging an error in the data in that config object, not any problem with the validation constraints themselves.

Regarding #18 did you run updb? When I applied the MR, before running updb, I saw the error in configuration inspector.

On a standard 11.x profile install
Installed configuration inspector
Applied the MR
Ran drush updb

Reviewing the code thanks @phenaproxima for pointing out scope issue.

Searched for .feedback.yml files and all appear to be updated.

Believe this one is good to go.

That was it. Thank you @smustgrave!

FWIW, this looks good to me, too.

This MR no prevents me from removing the message from a contact form. If I installed standard with this MR applied and go to admin/structure/contact/manage/feedback and remove all the text in the message field and press save the empty message field is not saved. If I remove the MR and a tried again I can empty the field and saves as expected.

Re #22, I updated the code to set values to NULL.
Reverting changes related to message(message: '') will fail ContactFormValidationTest.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I missed this issue when it was originally active, we should start by rerolling this.
Next we should look at https://git.drupalcode.org/project/drupal/-/merge_requests/7962#note_333039, to figure out how the schema should look.

Merged 11.x into this, lets see what happens.

Well, 2 test failures:

1. core/recipes/feedback_contact_form/recipe.yml -> The receipient input is not set when installing in core/tests/Drupal/Tests/Core/Recipe/RecipeQuickStartTest.php, so it fails since ${resipient} is not a vaild email adress.
2. core/tests/Drupal/FunctionalTests/Core/Recipe/StandardRecipeInstallTest.phphas the same issue, no recipient set.