- Issue created by @alexpott
- Status changed to Needs review
9 months ago 11:14am 15 July 2024 - Merge request !8771Add new constraint that allows blank values during install β (Open) created by alexpott
- Status changed to Needs work
9 months ago 11:56pm 21 July 2024 - πΊπΈUnited States smustgrave
Seems there may be other config that needs updating
Drupal\Tests\system\Functional\Datetime\DrupalDateTimeTest::testDateTimezone Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for system.date with the following errors: 0 [timezone.default] This value should not be null.
- π³π±Netherlands bbrala Netherlands
Hmm, no relations, setting a parent so it doesn't disappear. Seems rather usefull and quite isolated to implement.
- π³π±Netherlands bbrala Netherlands
Fun, when looking at the tests, (
core/modules/system/tests/src/Functional/Datetime/DrupalDateTimeTest.php:44
) it sets an empty timezone as default. But that it not really allowed, or at least, possible through the interface.So the test starts in a state which is not allowed. That is weird. Looking at the form, it would never happen, and if it was empty it would be the system default. Should that line be set to a default? Should we disable config validation there? Not sure.
- π³π±Netherlands bbrala Netherlands
Well, this is fun. There is quite a few ways to install config in tests, and a lot of times it installs the config as is default. This means without a value here. While installing only really checks when a install is ran, but not really if a module is being installed.
Not sure how we can do this, i mean, we would like to validate config that is being installed right? So its mostly something during testing, But not sure how to get to the end here.