- Issue created by @narendraR
- Status changed to Needs review
about 1 month ago 8:17am 22 May 2024 - First commit to issue fork.
- Status changed to RTBC
about 1 month ago 2:23pm 22 May 2024 - ๐บ๐ธUnited States smustgrave
Applied some nitpicky typehint return voids
Applied the MR to a 11.x install using standard profile
Believe the only entity_form_mode is for core.entity_form_mode.user.register
Ran updb and hook ran without issueManually downloaded config_inspector to 11.x setup and confirmed seeing fully validatable now
- Status changed to Needs work
about 1 month ago 12:57pm 23 May 2024 - ๐ฌ๐งUnited Kingdom catch
One issue with the presave hook on the MR - missing a deprecation notice.
- Status changed to Needs review
about 1 month ago 10:54am 27 May 2024 - Status changed to Needs work
about 1 month ago 2:42pm 27 May 2024 - Status changed to Needs review
about 1 month ago 7:04am 28 May 2024 - Status changed to RTBC
about 1 month ago 12:59pm 28 May 2024 - ๐บ๐ธUnited States smustgrave
Deprecation appears to be correct to me.
- Status changed to Needs work
about 1 month ago 2:34pm 28 May 2024 - ๐ฌ๐งUnited Kingdom catch
One small comment on the deprecation message. Hard to fit this sort of thing into the standard format.
- Status changed to Needs review
about 1 month ago 4:07pm 28 May 2024 - Status changed to RTBC
about 1 month ago 4:20pm 28 May 2024 - Status changed to Needs review
about 1 month ago 9:53pm 28 May 2024 - ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Left one question on the MR, great work here - bit more involved with the update hook!
- ๐ฎ๐ณIndia narendraR Jaipur, India
This issue is ready for re-review. I have added the return FALSE. Thanks
- Status changed to Needs work
about 1 month ago 1:04pm 29 May 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
Looks okay but I have a couple of questions here.
- Status changed to Needs review
27 days ago 9:16am 3 June 2024 - Status changed to Needs work
27 days ago 2:49pm 3 June 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
Only one tiny thing and then I think this looks good.
- Status changed to Needs review
25 days ago 8:03am 5 June 2024 - Status changed to RTBC
20 days ago 1:45pm 10 June 2024 - ๐บ๐ธUnited States smustgrave
Applied MR on a standard install for 11.x with config inspector and getting all green checks.
Looking at MR 8135 and from what I can tell all feedback has been addressed.
- Status changed to Needs work
3 days ago 8:28am 27 June 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
If I go to admin/structure/display-modes/form/ and edit the user registration form and save the form mode with no description then the system_entity_form_mode_presave() will trigger a deprecation notice.
We need to add something to the form to convert empty strings to NULLs... normally we'd say use #config_target but we've not worked out how to using #config_target like stuff with config entities yet.