Add config validation for workflow entities

$ ./vendor/bin/drush config:inspect --filter-keys=workflows.workflow.editorial --detail --list-constraints --fields=key,validatability,constraints ➜ 🤖 Analyzing… ------------------------------------------ ------------- --------------------------------------------------------------------------------- Key Validatable Validation constraints ------------------------------------------ ------------- --------------------------------------------------------------------------------- workflows.workflow.editorial 53% ValidKeys: '<infer>' workflows.workflow.editorial: Validatable ValidKeys: '<infer>' workflows.workflow.editorial:_core Validatable ValidKeys: - default_config_hash workflows.workflow.editorial:_core.defa Validatable NotNull: { } ult_config_hash Regex: '/^[a-zA-Z0-9\-_]+$/' Length: 43 ↣ PrimitiveType: { } workflows.workflow.editorial:dependenci Validatable ValidKeys: '<infer>' es workflows.workflow.editorial:dependenci NOT ❌ @todo Add validation constraints to ancestor type: config_dependencies es.module workflows.workflow.editorial:dependenci Validatable NotBlank: { } es.module.0 ExtensionName: { } ExtensionExists: module ↣ PrimitiveType: { } workflows.workflow.editorial:id Validatable Regex: pattern: '/^[a-z0-9_]+$/' message: 'The %value machine name is not valid.' Length: max: 166 ↣ PrimitiveType: { } workflows.workflow.editorial:label Validatable Regex: pattern: '/([^\PC])/u' match: false message: 'Labels are not allowed to span multiple lines or contain control characters.' NotBlank: { } ↣ PrimitiveType: { } workflows.workflow.editorial:langcode Validatable NotNull: { } Choice: callback: 'Drupal\Core\TypedData\Plugin\DataType\LanguageReference::getAllValidLangcodes' ↣ PrimitiveType: { } workflows.workflow.editorial:status Validatable ↣ PrimitiveType: { } workflows.workflow.editorial:type Validatable PluginExists: manager: plugin.manager.workflows.type interface: Drupal\workflows\WorkflowTypeInterface ↣ PrimitiveType: { } workflows.workflow.editorial:type_setti Validatable ValidKeys: '<infer>' ngs workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: ngs.default_moderation_state workflow.type_settings.content_moderation workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: ngs.entity_types workflow.type_settings.content_moderation workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: ngs.states workflow.type_settings.content_moderation workflows.workflow.editorial:type_setti Validatable ValidKeys: '<infer>' ngs.states.archived workflows.workflow.editorial:type_setti Validatable ↣ PrimitiveType: { } ngs.states.archived.default_revision workflows.workflow.editorial:type_setti Validatable Regex: ngs.states.archived.label pattern: '/([^\PC])/u' match: false message: 'Labels are not allowed to span multiple lines or contain control characters.' ↣ PrimitiveType: { } workflows.workflow.editorial:type_setti Validatable ↣ PrimitiveType: { } ngs.states.archived.published workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: content_moderation.state ngs.states.archived.weight workflows.workflow.editorial:type_setti Validatable ValidKeys: '<infer>' ngs.states.draft workflows.workflow.editorial:type_setti Validatable ↣ PrimitiveType: { } ngs.states.draft.default_revision workflows.workflow.editorial:type_setti Validatable Regex: ngs.states.draft.label pattern: '/([^\PC])/u' match: false message: 'Labels are not allowed to span multiple lines or contain control characters.' ↣ PrimitiveType: { } workflows.workflow.editorial:type_setti Validatable ↣ PrimitiveType: { } ngs.states.draft.published workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: content_moderation.state ngs.states.draft.weight workflows.workflow.editorial:type_setti Validatable ValidKeys: '<infer>' ngs.states.published workflows.workflow.editorial:type_setti Validatable ↣ PrimitiveType: { } ngs.states.published.default_revision workflows.workflow.editorial:type_setti Validatable Regex: ngs.states.published.label pattern: '/([^\PC])/u' match: false message: 'Labels are not allowed to span multiple lines or contain control characters.' ↣ PrimitiveType: { } workflows.workflow.editorial:type_setti Validatable ↣ PrimitiveType: { } ngs.states.published.published workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: content_moderation.state ngs.states.published.weight workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: ngs.transitions workflow.type_settings.content_moderation workflows.workflow.editorial:type_setti Validatable ValidKeys: '<infer>' ngs.transitions.archive workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archive.from workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archive.from.0 workflows.workflow.editorial:type_setti Validatable Regex: ngs.transitions.archive.label pattern: '/([^\PC])/u' match: false message: 'Labels are not allowed to span multiple lines or contain control characters.' ↣ PrimitiveType: { } workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archive.to workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archive.weight workflows.workflow.editorial:type_setti Validatable ValidKeys: '<infer>' ngs.transitions.archived_draft workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archived_draft.from workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archived_draft.from.0 workflows.workflow.editorial:type_setti Validatable Regex: ngs.transitions.archived_draft.label pattern: '/([^\PC])/u' match: false message: 'Labels are not allowed to span multiple lines or contain control characters.' ↣ PrimitiveType: { } workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archived_draft.to workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archived_draft.weight workflows.workflow.editorial:type_setti Validatable ValidKeys: '<infer>' ngs.transitions.archived_published workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archived_published.from workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archived_published.from. 0 workflows.workflow.editorial:type_setti Validatable Regex: ngs.transitions.archived_published.label pattern: '/([^\PC])/u' match: false message: 'Labels are not allowed to span multiple lines or contain control characters.' ↣ PrimitiveType: { } workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archived_published.to workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.archived_published.weigh t workflows.workflow.editorial:type_setti Validatable ValidKeys: '<infer>' ngs.transitions.create_new_draft workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.create_new_draft.from workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.create_new_draft.from.0 workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.create_new_draft.from.1 workflows.workflow.editorial:type_setti Validatable Regex: ngs.transitions.create_new_draft.label pattern: '/([^\PC])/u' match: false message: 'Labels are not allowed to span multiple lines or contain control characters.' ↣ PrimitiveType: { } workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.create_new_draft.to workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.create_new_draft.weight workflows.workflow.editorial:type_setti Validatable ValidKeys: '<infer>' ngs.transitions.publish workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.publish.from workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.publish.from.0 workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.publish.from.1 workflows.workflow.editorial:type_setti Validatable Regex: ngs.transitions.publish.label pattern: '/([^\PC])/u' match: false message: 'Labels are not allowed to span multiple lines or contain control characters.' ↣ PrimitiveType: { } workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.publish.to workflows.workflow.editorial:type_setti NOT ❌ @todo Add validation constraints to ancestor type: workflows.transition ngs.transitions.publish.weight workflows.workflow.editorial:uuid Validatable Uuid: { } ↣ PrimitiveType: { } ------------------------------------------ ------------- ---------------------------------------------------------------------------------

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 11 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
See the parent issue — several config entity types in Drupal core are now fully validatable! 🚀
Assigned to wim leers
Comment 11 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I'll get this going…
Merge request !6696Draft: Resolve #2920441 "Workflow config validation" → (Open) created by wim leers
Issue was unassigned.
Status changed to Needs review 11 months ago10:52am 20 February 2024
Comment 11 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This MR gets us to 100% validatability, but at the last moment I discovered there was a whole new edge case: predefined_states_workflow_test_type — where possible states are NOT defined in the config 😬

Anyway, this should still serve as a good starting point 👍

P.S.: this might be blocked on 🐛 Sequences of mappings cannot merge keys from a subsequent definition of mapping keys Needs work ?
Pipeline finished with Failed
11 months ago
Total: 689s
#99318
Comment 11 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
The test failures seem to have revealed a long-standing bug in how %parent.%key works for a nested sequence item 😬 We'll need to fix that first.
Comment 11 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
The ExistsIn constraint I wrote for this MR is already useful in another: see #3422862-4: Add validation constraints to book.settings → .
Status changed to Postponed 11 months ago5:16pm 21 February 2024
Comment 11 months ago →
🇺🇸United States smustgrave
Seems this is postponed on 🐛 Sequences of mappings cannot merge keys from a subsequent definition of mapping keys Needs work

Also left a comment in [#15456258] about breaking that up.
Status changed to Needs work 11 months ago5:34pm 21 February 2024
Comment 11 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
That's not yet certain. 😅 Plus, we can continue here regardless of that.

Add config validation for workflow entities

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!6696Add config validation for workflow entities
Open

Comments & Activities

Add config validation for workflow entities

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!6696Add config validation for workflow entitiesOpen

Comments & Activities

!6696Add config validation for workflow entities
Open