- ๐บ๐ธUnited States smustgrave
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
- ๐บ๐ธUnited States smustgrave
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
- ๐ง๐ชBelgium borisson_ Mechelen, ๐ง๐ช
All feedback that I had suggested is now fixed.
- ๐ง๐ชBelgium borisson_ Mechelen, ๐ง๐ช
I think overall this looks great, I have a tiny documentation nitpick and a small change I'd like to see in the tests.
- ๐ณ๐ฑNetherlands bbrala Netherlands
Changes look good, fixed one test, i think we should be green now. Preemptively setting to NR
- ๐ณ๐ฑNetherlands bbrala Netherlands
I honestly hate how the error measages are. This was quite the challenge to update the expected errors.
I think we are green now, but ill have a look at the changes first to see if i didnt add changes that sign it might be a bit break.
- ๐ง๐ชBelgium borisson_ Mechelen, ๐ง๐ช
I agree with #97, I don't think we need an update path, but we do need to mention in the change record that saving after this update will trigger a lot of extra exports.
It's good to see that you already removed the novice tag again @bbrala, because this doesn't look very easy.
- ๐ณ๐ฑNetherlands bbrala Netherlands
๐ Add validation constraints to core.menu.schema.yml Needs work landed.