🇧🇪Belgium @L_VanDamme

Account created on 18 February 2015, over 9 years ago
#

Recent comments

🇧🇪Belgium L_VanDamme

I updated the MR to stop using RouteMatch parameters or request attributes as they are not reliable. Instead, we should use the Route defaults as we can be 100% sure they will be present and correct (as we set them ourselves).

This is needed because we have noticed very rare edge cases where the page entity could not be found in the RouteMatch parameters or request attributes. In our case this was most easily reproduced right after logging in with users that have a certain role. I did not debug what was actually causing this in code.

🇧🇪Belgium L_VanDamme

I added some lines to the existing patch (the part of the access check) that load the page manager page entity if it is not loaded already. This seems to fix the access issues in our usecase (language switch links).

This does feel a lot like a bandaid for a bigger issue though, more investigation would be nice. Especially by someone more familiar with the routing system and the way parameters are being upcast to objects.

🇧🇪Belgium L_VanDamme

Reuploading patch as I missed the file deletions

🇧🇪Belgium L_VanDamme

Separate patch that applies to 1.0.1 (due to packaging information on info.yml)

🇧🇪Belgium L_VanDamme

I set up a MR with the new code (with some additions and improvements to my previous .zip file)

🇧🇪Belgium L_VanDamme

Uploading a patch I used for a project that implements the second possible solution (updating the database schema), because they specifically wanted to be able to use longer titles.

This patch was made on the 6.0.0-alpha38 version of this module, but should work on later versions as well.

🇧🇪Belgium L_VanDamme

Added a patch based on the open MR

🇧🇪Belgium L_VanDamme

Uploading a patch file based on the open MR

Production build 0.69.0 2024