- Issue created by @L_VanDamme
- π¦πΊAustralia pameeela
@l_vandamme are there any blockers to this?
- π§πͺBelgium L_VanDamme
@phenaproxima There's some tests failing but I don't think it is blog related. Let me know if there is something to fix.
Side note, I enabled layout builder and overrides for basic pages because we will need it to set up overviews that way. We can not use it at this point because core causes some issues when trying to import serialized layout builder sections (see https://www.drupal.org/project/drupal/issues/2942975 π [PP-1] Expose Layout Builder data to REST and JSON:API Postponed ). Depending on how much we want this way of working in v1, we might need to add some pressure there.
- πΊπΈUnited States phenaproxima Massachusetts
Two questions:
- Looks good, but why were Blog's entity view and form displays removed?
- Are we planning to implement LB in any other content types? If not, we should probably do this change in the Page recipe only.
- π§πͺBelgium L_VanDamme
@phenaproxima As I understood it, we are planning to use layout builder on all content types. 1 thing that is in contention still is whether we'll be using the layout builder overrides for overview pages.
As for the view and form displays, I moved them to the recipe.yml as config actions to allow them to be overridden without causing issues when reapplying the recipe. This was due to a discussion about when we should allow for these kind of changes and when not, and the way I see it, if there's recipes in drupal_cms (or in a future version of it) that would alter the config, it might be better to have it as config actions and so allow overrides.
Let me know if this doesn't make sense. - πΊπΈUnited States phenaproxima Massachusetts
As for the view and form displays, I moved them to the recipe.yml as config actions to allow them to be overridden without causing issues when reapplying the recipe.
No need to do this. The
strict: false
flag (or selective strictness) will fix it. See the documentation at https://www.drupal.org/node/3478662 β . Can you revert that change? - π§πͺBelgium L_VanDamme
@phenaproxima I moved the entity displays back to the config folder (will do so for news as well in that ticket) and fixed the related blog posts view while I was at it.
- π¦πΊAustralia pameeela
As I understood it, we are planning to use layout builder on all content types.
We won't have overrides enabled for all, only basic page. But we will use it for other content types to customise the default display.
- πΊπΈUnited States phenaproxima Massachusetts
This seems fine to me but I believe there was a crossed wire or two with regard to
field_image
(which is gone) andfield_featured_image
(which replaced it).Otherwise I'd say this is RTBC.
- π¦πΊAustralia pameeela
Discussed with @phenaproxima and the field name is definitely a mistake, let's get it merged with the updated/agreed field_featured_image.
- πΊπΈUnited States phenaproxima Massachusetts
There you go, right from Pam - it's RTBC.
-
phenaproxima β
committed 11524518 on 0.x authored by
l_vandamme β
Issue #3485822 by l_vandamme, phenaproxima: Add Layout Builder to the...
-
phenaproxima β
committed 11524518 on 0.x authored by
l_vandamme β
- πΊπΈUnited States phenaproxima Massachusetts
Great! Now the rest of our content types are unblocked. Merged into 0.x.
Automatically closed - issue fixed for 2 weeks with no activity.