- Issue created by @L_VanDamme
- π§πͺBelgium L_VanDamme
Currently holding off on this until layout builder has been implemented in blog.
- π§πͺBelgium L_VanDamme
@phenaproxima Can you review? Build job is currently failing, but local test runs were ok for the news recipe.
- πΊπΈUnited States phenaproxima Massachusetts
Looks okay at cursory glance, with one question about the code so far. In order to ensure the tests run, please add this new recipe to the
.components
job in.gitlab-ci.yml
. Also, this recipe isn't enabled by anything - you should probably add it to the suggested list ofrecipes/drupal_cms_starter/composer.json
, and therequire
list ofproject_template/composer.json
(and the repositories list incomponents.composer.json
). - π§πͺBelgium L_VanDamme
@phenaproxima Updated the MR. I also took the opportunity to update the blog description and to add news to the CODEOWNERS file.
- πΊπΈUnited States phenaproxima Massachusetts
That's a good idea. One thing I forgot - please add the new recipe to the list of recipes exposed to Project Browser (see
recipes/drupal_cms_starter/recipe.yml
). - πΊπΈUnited States phenaproxima Massachusetts
Never mind #7 - looks like you already did it (thank you)!
- π§πͺBelgium L_VanDamme
@phenaproxima I changed the news description everywhere I could find it and added the licensing stuff. Having some troubles with a rebase though, can you have a look?
- π§πͺBelgium L_VanDamme
@phenaproxima I did another pass, properly rebasing, updating the licensing stuff to what is now in 0.x and moving the entity displays to config as we did for blog. Should be good to go now.
- πΊπΈUnited States phenaproxima Massachusetts
I found virtually nothing to complain about, just one pretty minor thing and one entirely optional nit.
- πΊπΈUnited States phenaproxima Massachusetts
Eff it, we gotta get this going. I'll deal with my nitpicks and RTBC this.
- πΊπΈUnited States phenaproxima Massachusetts
Postponed because this uses Layout Builder for the display, which is happening in π Implement Layout builder Active .
- π¦πΊAustralia pameeela
There are some minor changes needed but happy to address them in a follow up.
-
phenaproxima β
committed ed465c5e on 0.x authored by
l_vandamme β
Issue #3487438 by l_vandamme, phenaproxima: Create a news recipe
-
phenaproxima β
committed ed465c5e on 0.x authored by
l_vandamme β
Automatically closed - issue fixed for 2 weeks with no activity.