Create a news recipe

Created on 14 November 2024, about 1 month ago

Problem/Motivation

News content type should be set up as a "copy" of blog, containing the same functionalities.
Any adaptations specifically for news can be added as separate tickets later.

πŸ“Œ Task
Status

Active

Component

Track: Blog

Created by

πŸ‡§πŸ‡ͺBelgium L_VanDamme

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @L_VanDamme
  • πŸ‡§πŸ‡ͺBelgium L_VanDamme

    Currently holding off on this until layout builder has been implemented in blog.

  • Merge request !245Add news recipe β†’ (Merged) created by L_VanDamme
  • Pipeline finished with Canceled
    29 days ago
    Total: 63s
    #351568
  • Pipeline finished with Canceled
    29 days ago
    Total: 64s
    #351569
  • Pipeline finished with Failed
    29 days ago
    Total: 67s
    #351570
  • Pipeline finished with Failed
    29 days ago
    Total: 210s
    #351571
  • πŸ‡§πŸ‡ͺBelgium L_VanDamme

    @phenaproxima Can you review? Build job is currently failing, but local test runs were ok for the news recipe.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Looks okay at cursory glance, with one question about the code so far. In order to ensure the tests run, please add this new recipe to the .components job in .gitlab-ci.yml. Also, this recipe isn't enabled by anything - you should probably add it to the suggested list of recipes/drupal_cms_starter/composer.json, and the require list of project_template/composer.json (and the repositories list in components.composer.json).

  • πŸ‡§πŸ‡ͺBelgium L_VanDamme

    @phenaproxima Updated the MR. I also took the opportunity to update the blog description and to add news to the CODEOWNERS file.

  • Pipeline finished with Failed
    29 days ago
    Total: 1587s
    #352026
  • Pipeline finished with Failed
    29 days ago
    Total: 1667s
    #352025
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    That's a good idea. One thing I forgot - please add the new recipe to the list of recipes exposed to Project Browser (see recipes/drupal_cms_starter/recipe.yml).

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Never mind #7 - looks like you already did it (thank you)!

  • Pipeline finished with Canceled
    28 days ago
    Total: 184s
    #352792
  • Pipeline finished with Canceled
    28 days ago
    Total: 186s
    #352793
  • πŸ‡§πŸ‡ͺBelgium L_VanDamme

    @phenaproxima I changed the news description everywhere I could find it and added the licensing stuff. Having some troubles with a rebase though, can you have a look?

  • Pipeline finished with Failed
    28 days ago
    Total: 1178s
    #352797
  • Pipeline finished with Failed
    28 days ago
    Total: 1195s
    #352796
  • Pipeline finished with Failed
    28 days ago
    Total: 45s
    #352842
  • Pipeline finished with Failed
    28 days ago
    Total: 48s
    #352841
  • Pipeline finished with Failed
    28 days ago
    Total: 74s
    #352861
  • Pipeline finished with Failed
    28 days ago
    Total: 75s
    #352862
  • πŸ‡§πŸ‡ͺBelgium L_VanDamme

    @phenaproxima I did another pass, properly rebasing, updating the licensing stuff to what is now in 0.x and moving the entity displays to config as we did for blog. Should be good to go now.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    I found virtually nothing to complain about, just one pretty minor thing and one entirely optional nit.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Eff it, we gotta get this going. I'll deal with my nitpicks and RTBC this.

  • Pipeline finished with Canceled
    24 days ago
    Total: 51s
    #356938
  • Pipeline finished with Failed
    23 days ago
    Total: 73s
    #356940
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Postponed because this uses Layout Builder for the display, which is happening in πŸ“Œ Implement Layout builder Active .

  • Pipeline finished with Failed
    23 days ago
    Total: 107s
    #356953
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Blocker's in.

  • Pipeline finished with Failed
    23 days ago
    Total: 72s
    #356968
  • Pipeline finished with Canceled
    23 days ago
    Total: 182s
    #357027
  • Pipeline finished with Failed
    23 days ago
    Total: 527s
    #357030
  • πŸ‡¦πŸ‡ΊAustralia pameeela

    There are some minor changes needed but happy to address them in a follow up.

  • Pipeline finished with Skipped
    23 days ago
    #357099
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Merged into 0.x. Thank you!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024