- Issue created by @candelas
- ๐ฎ๐ณIndia ravi kant Jaipur
@candelas
The format is not ok according to README.md template suggestions โ . - First commit to issue fork.
- Status changed to Needs review
11 months ago 10:51am 12 February 2024 - ๐ฎ๐ณIndia sakthi_dev
Thanks @candelas @ravi-kant. Created a MR for creating Readme file.
- ๐ช๐ธSpain candelas
@ravi kant you are right. Thanks for the link. I was making something fast, but better well done.
@sakthi_dev now I am leaving the computer and can't make the changes. Would you like to make them? If not, later this week, I can :) - Status changed to Needs work
11 months ago 7:42am 13 February 2024 - ๐ต๐ญPhilippines kenyoOwen
Hi sakthi_dev
I reviewed your MR!6 and it doesn't address comment #2. This should be needs work status.
Thank you
- ๐ช๐ธSpain candelas
Hello
For what I see in my agenda, I will be able to collaborate to implement #2 the weekend.
@sakthi_dev if you have not made it before, you can later copy and paste.Have a good day
- ๐ฎ๐ณIndia Raveen Kumar
Raveen Thakur โ made their first commit to this issueโs fork.
- Status changed to Needs review
11 months ago 9:25am 13 February 2024 - ๐ช๐ธSpain candelas
@Raveen Thakur you are fast! :)
I miss the main reason that made me propose the readme: to have the command in it and not to have to search in the code. As a site builder, I find it very useful.
Thanks for your work - Status changed to Needs work
11 months ago 6:33am 14 February 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!6, the patch is not cleanly applied.
1. 6.diff.txt:41: trailing whitespace. warning: 1 line adds whitespace errors. 2. In Table of contents, Recommended module is given however, details section of recommended module is missing.
- Status changed to Needs review
11 months ago 6:41am 14 February 2024 - ๐ช๐ธSpain candelas
@ravi-kant tomorrow I will have time to work in the Drupal site.
@raveen-thakur doesn't considere that including the drush command is important.
For me the README.md function is facilitate to the user the module learning.
If that is not going to be in it, thanks for all and here finish my collaboration :)Have a good day!
- Status changed to Needs work
11 months ago 10:02am 15 February 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!6, the file has still some issues:
1. 6.diff.txt:40: trailing whitespace. warning: 1 line adds whitespace errors.
- ๐ฎ๐ณIndia Raveen Kumar
@Nupur, which testing method you are following on it?
- Status changed to Needs review
11 months ago 1:12pm 15 February 2024 - Status changed to RTBC
11 months ago 4:32am 16 February 2024 - ๐ต๐ญPhilippines paraderojether
Hi Raveen Thakur,
I reviewed MR!6, applied against Config import single 2.0.x-dev, and confirmed the MR is applied and the README.md is also added.
I attached screenshots for reference.
Thank you. - Status changed to Needs work
11 months ago 7:41am 16 February 2024 - ๐ต๐ญPhilippines kenyoOwen
Hi Raveen Thakur
I reviewed your changes in MR!6 and
Project name and introduction
is missing dotconsole into drush
and you shouldn't say module only instead ofThe Config import single module
on introduction. For the Requirements section since drush is a core module replace the requirements section toThis module requires no modules outside of Drupal core.
Thank you
- Status changed to Needs review
11 months ago 10:49am 16 February 2024 - Status changed to RTBC
11 months ago 8:22am 20 February 2024 - ๐ต๐ญPhilippines kenyoOwen
Hi Raveen Thakur
I reviewed your changes in MR!6, which addressed comment #20 and the README.md is following the template. โ
Thank you.