- πΊπΈUnited States smustgrave
For the change record mentioned in #40.
Did not test patch.
- π§πͺBelgium borisson_ Mechelen, π§πͺ
Added a basic change record. Keeping this on needs work for the documentation.
- Status changed to Needs review
about 1 year ago 11:34am 6 November 2023 - last update
about 1 year ago 30,488 pass - Status changed to RTBC
about 1 year ago 4:02pm 6 November 2023 - πΊπΈUnited States smustgrave
CR has been added, in addition to the added comments.
Manually ran the tests and all green.
Could this of been used between 9 and 10 to uninstall classy?
- last update
about 1 year ago 29,260 pass, 20 fail - Status changed to Needs work
about 1 year ago 9:00am 7 November 2023 - π¬π§United Kingdom alexpott πͺπΊπ
+++ b/core/lib/Drupal/Core/Extension/ThemeInstaller.php @@ -266,9 +266,6 @@ public function uninstall(array $theme_list) { - if (!isset($list[$key])) { - throw new UnknownExtensionException("Unknown theme: $key."); - }
I think we should replace this with
if ($extension_config->get("theme.$key") === NULL) { throw new UnknownExtensionException("Unknown theme: $key."); }
So we can only uninstall themes that are listed in the core.extension.
Otherwise this happens:
vendor/bin/drush thun blah [warning] The following theme is missing from the file system: blah ExtensionPathResolver.php:63 [success] Successfully uninstalled theme: blah
- Status changed to Needs review
about 1 year ago 2:38pm 8 November 2023 - last update
about 1 year ago 30,510 pass - πΊπΈUnited States smustgrave
Manually triggering tests and hiding old patches.
- Status changed to RTBC
about 1 year ago 4:14pm 8 November 2023 - πΊπΈUnited States smustgrave
All green. And feedback from #47 has been addressed.
- Status changed to Fixed
about 1 year ago 5:01pm 8 November 2023 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed bfc5c6d181c to 11.x and 01b19986028 to 10.2.x. Thanks!
Backported to 10.2.x as a non-disruptive bugfix.
-
alexpott β
committed bfc5c6d1 on 11.x
Issue #2898274 by aleevas, piotrkonefal, borisson_, GaΓ«lG, ankithashetty...
-
alexpott β
committed bfc5c6d1 on 11.x
-
alexpott β
committed 01b19986 on 10.2.x
Issue #2898274 by aleevas, piotrkonefal, borisson_, GaΓ«lG, ankithashetty...
-
alexpott β
committed 01b19986 on 10.2.x
Automatically closed - issue fixed for 2 weeks with no activity.