🇮🇳India @nitesh624

Yes the changes in MR working for me.

So the problem is:
Since in hook_entity_bundle_field_info_alter() we are using typed parameter so whenever $default_fields = \Drupal::service('entity_field.manager')->getFieldDefinitions('paragraph', NULL); line executes, the hook_entity_bundle_field_info_alter() hook also invoked and since 2nd parameter is passed NULL from section_library module. It breaks here due to type mismatched.

No Its not necessary that hook contain media entity.
If my hook is like below still its causing the failure

function custom_media_entity_bundle_field_info_alter(array &$fields, EntityTypeInterface $entity_type, string $bundle): ?array {
    $fields = [];
    return $fields;
}

And I found out why we are getting error here
The issue is in https://git.drupalcode.org/project/section_library/-/blob/2.0.0/src/Deep... line
$default_fields = \Drupal::service('entity_field.manager')->getFieldDefinitions('paragraph', NULL);

So what I did I remove the above line and added below line within the foreach look just below it

$default_fields = \Drupal::service('entity_field.manager')->getFieldDefinitions('paragraph', $paragraph->getType());

foreach ($value as $key => $item) {
        // createDuplicates() creates a duplicate with the same parent_id.
        // Our duplicate needs to be independent of original inline block id.
        $paragraph = $paragraph_storage->load($item['target_id']);
$default_fields = \Drupal::service('entity_field.manager')->getFieldDefinitions('paragraph', $paragraph->getType());
....
....

Then Its working fine for me

This seems to be broken after https://git.drupalcode.org/project/section_library/-/commit/f338ef84ae79... commit

nitesh624 → created an issue.

Still seeing the below error
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for search_api.server.pantheon_search with the following errors: search_api.server.pantheon_search:backend_config.disabled_request_handlers variable type is NULL but applied schema class is Drupal\Core\Config\Schema\Sequence, search_api.server.pantheon_search:backend_config.disabled_request_dispatchers variable type is NULL but applied schema class is Drupal\Core\Config\Schema\Sequence

Closing as it will be fix in https://www.drupal.org/project/section_library/issues/3512185 🐛 Existing test are failing after new section library module update Active

yes that MR fixes my issue

https://git.drupalcode.org/project/section_library/-/merge_requests/52#n... MR works for me RTBC+1

ok let me try

Still my test is failing

 Drupal\Tests\my_custom_module\Functional\PageContentTest::testPageModule
Drupal\Core\Config\PreExistingConfigException: Configuration objects (image.style.medium) provided by section_library already exist in active configuration

nitesh624 → created an issue.

nitesh624 → created an issue.

Still I am getting the schema issue after applying patch
Schema errors for search_api.server.pantheon_search with the following errors: search_api.server.pantheon_search:backend_config.disabled_request_handlers variable type is NULL but applied schema class is Drupal\Core\Config\Schema\Sequence, search_api.server.pantheon_search:backend_config.disabled_request_dispatchers variable type is NULL but applied schema class is Drupal\Core\Config\Schema\Sequence

nitesh624 → created an issue.

nitesh624 → created an issue.

Bot in our existing index config we are using

dependencies:
  config:
    - search_api.server.pantheon_solr8
server: pantheon_solr

So as per the change in 8.3.1 version we need to update this to pantheon_search ?

nitesh624 → created an issue.

I see this issue is closed . When we are expecting a new release of this as due to this we are not able to upgrade ctools to 4.x version,

This I can reproduce on 7.x version of module also.

I still see focus is lost on text field . So I guess we need to reopen this

Buy why this commit https://git.drupalcode.org/project/better_exposed_filters/-/commit/39fd0... has been done not as a part of this issue.

I see https://git.drupalcode.org/project/better_exposed_filters/-/commit/39fd0... commit has the changes from the patch https://www.drupal.org/files/issues/2022-10-27/auto-submit-textfield-foc... →
Is it resolved in version 7.0.2

I am also getting error during test run locally

PHPUnit\Framework\Exception: PHP Deprecated: image_type_to_extension(): Passing null to parameter #1 ($image_type) of type int is deprecated in web/core/modules/system/src/Plugin/ImageToolkit/Operation/gd/Resize.php on line 63

patch from #24 does not apply on 7.0.2 version.

So should we Avoid this warning from drupal core side like https://www.drupal.org/project/drupal/issues/3261924 🐛 Avoid warning from imagecreatefrompng when loading png with obscure iCCP profiles Needs work .
And I see fixes in https://www.drupal.org/project/drupal/issues/3261924 🐛 Avoid warning from imagecreatefrompng when loading png with obscure iCCP profiles Needs work fixes this warning also. I am wondering if we can just update the test with scenario from this issue also

ok

Is this warning generated through issue in image file?

But what was the exact scenario which https://www.drupal.org/project/easy_breadcrumb/issues/3421745 🐛 Home page segment not rendered as a link Fixed fixes?

and I still don't get your Problem... If you are On the Homepage.. and there is a breadcrumb.. what is the point of putting out a link to the page I am on... since you got a custom Url... that you want to link to...

Yes for the first breadcrumb item I want to print a custom external url of another site.

but is this a kind of workaround solution?

@spuky thanks for snippet in #9. Thats worked for me. It will falls under no url case

I tried {{ custom_url|raw }} but that is also not working. Seems it would be great of you can make the changes make in https://www.drupal.org/project/easy_breadcrumb/issues/3421745 🐛 Home page segment not rendered as a link Fixed to include as part of config. As some sites might need to rendered home page as link in first breadcrumb

Here is my overriden twig

{% if breadcrumb %}
  <nav class="breadcrumb" role="navigation" aria-labelledby="system-breadcrumb">
    <h2 id="system-breadcrumb" class="visually-hidden">{{ 'Breadcrumb'|t }}</h2>
    <ol>
    {% for item in breadcrumb %}
      <li>
        {% if item.url %}
          {# Check the First Breadcrumb and custom #}
          {% if loop.first %}
            <a href="{{ custom_url }}">{{ item.text }}</a>
          {% else %}
            <a href="{{ item.url }}">{{ item.text }}</a>
          {% endif %}
        {% else %}
          {{ item.text }}
        {% endif %}
      </li>
    {% endfor %}
    </ol>
  </nav>
{% endif %}

nitesh624 → created an issue.

I am also getting this warning.

There is one more warning occurring in image system https://www.drupal.org/project/drupal/issues/3474274 💬 GDToolkit::load() error: 'iCCP: too many profiles' Active

the patch from #7 is working fine for me with drupal 10.3.5. this is major issue for editor after 10.3 upgrade. This need to be fixed asap. But as per comment in #19 "Of course I'm not sure if the proposed resolution is acceptable at all, as it doesn't really fix the root cause." which gives us bit hesitation in apply the patch from #7 for our project and uninstalling settings_tray also might impact the existing editing experience for editors.

for me its happening when I upgrade my site drupal core version from 10.2.8 to 10.3.4.
Is there something change in 10.3 version which causing this schema error

yes agreed with #10. this patch should be optional

Yes with access policy approach we were able to get that working after adding cacheability .

But I am asking about the config override approach (below code)

class PermissionOverrides implements ConfigFactoryOverrideInterface {

/**
  * {@inheritdoc}
  */
public function loadOverrides($names) {
  $overrides = [];
  $role = 'user.role.test_role';
  if (in_array($role, $names)) {
    $types = $this->entityTypeManager()->getStorage('node_type')->loadMultiple();
    foreach ($types as $type) {
      $permission = 'Test permission ' . $type->id();
      $overrides[$role]['permissions'][$permission] = $permission;
    }
  }

  return $overrides;
}

/**
 * @return string
 */
public function getCacheSuffix() {
  return static::class;
}

/**
 * @param string $name
 *
 * @return \Drupal\Core\Cache\CacheableMetadata
 */
public function getCacheableMetadata($name) {
  return new CacheableMetadata();
}

/**
 * @param mixed $name
 * @param string $collection
 *
 * @return \Drupal\Core\Config\StorableConfigBase|null
 */
public function createConfigObject($name, $collection = StorageInterface::DEFAULT_COLLECTION) {
  return NULL;
}

}

Code snippets for Content type creation in Functional Test.

$this->drupalCreateContentType(['type' => 'test_content', 'name' => 'test_content']);

The above code is not working after inclusion of permission policy api. Means the test_content content type which we are creating in Functional test is not coming in the $types = $this->entityTypeManager()->getStorage('node_type')->loadMultiple();

When I debug more on this I found that on web/core/lib/Drupal/Core/Session/PermissionChecker.php file under hasPermission(), When I reverted back the changes committed in https://git.drupalcode.org/project/drupal/-/commit/9bb46296cee3aa33a9750... commit, Then my config override method is working fine

Code snippet is there in the issue summary

But in my case newly created node
Type in functional test is not coming in config override service, Unless we forcefully clear the cache in functional test.

So somthing cache related in permission policy api causing this behaviour in our drupal site

I agreed with https://www.drupal.org/project/drupal/issues/3463722#comment-15717005 🐛 ConfigFactoryOverrideInterface::loadOverrides not invoked after content type creation in Drupal 10.3.0+ Active . But will the caching changes affect the outcome of
$types = \Drupal::entityTypeManager()->getStorage('node_type')->loadMultiple(); in above code snippet, when we are creating node in a Functional test like $this->drupalCreateContentType(['type' => 'test_content', 'name' => 'test_content']); ?

Hoping This should be committed soon as there is security issue mentioned in https://www.drupal.org/project/views_data_export/issues/3388703#comment-... 🐛 Deprecated call to setCellValueByColumnAndRow Active

MR27 worked for me also

Ok thanks

Worked for me

Yes this is much needed and it will be great if this module get a security release asap. Thanks

nitesh624 → created an issue.

nitesh624 → created an issue.

Are we expecting a new release for this issue as this blocks us to upgrade ctools to 4.x version?

Here is my code snippet
-> custom_access/src/Access/AccessUnpublishedPermission.php

<?php

namespace Drupal\custom_access\Access;

use Drupal\Core\Session\AccessPolicyBase;
use Drupal\Core\Session\AccountInterface;
use Drupal\Core\Session\CalculatedPermissionsItem;
use Drupal\Core\Session\RefinableCalculatedPermissionsInterface;

/**
 * Using the access policy API to allow  users to view unpublished content.
 */
class AccessUnpublishedPermission extends AccessPolicyBase {

  /**
   * {@inheritdoc}
   */
  public function calculatePermissions(AccountInterface $account, string $scope): RefinableCalculatedPermissionsInterface {
    $calculated_permissions = parent::calculatePermissions($account, $scope);
    $types = \Drupal::entityTypeManager()->getStorage('node_type')->loadMultiple();
    $permission = [];
    foreach ($types as $type) {
      $permission[] = 'access_unpublished node ' . $type->id();
    }

    // If we aren't an anonymous user, return early.
    if (!in_array('anonymous', $account->getRoles())) {
      return $calculated_permissions;
    }

    return $calculated_permissions->addItem(new CalculatedPermissionsItem($permission));
  }

  public function getPersistentCacheContexts(): array {
    return ['user.roles:anonymous'];
  }

}

-> custom_access.services.yml

services:
  custom_access.access_policy.access_unpublished_permission:
    class: Drupal\custom_access\Access\AccessUnpublishedPermission
    tags:
      - { name: access_policy }

Then in Functional Test I am creating a test content type like below
$this->drupalCreateContentType(['type' => 'test_content', 'name' => 'test_content']);

The problem is after creating the content type like this in test, \Drupal::entityTypeManager()->getStorage('node_type')->loadMultiple();
service in AccessUnpublishedPermission.php file does not include the test_content content type

I have update my custom code to assign permission through access policy but facing same issue

This changes caused out Functional test to failed
More details on https://www.drupal.org/project/drupal/issues/3463722 🐛 ConfigFactoryOverrideInterface::loadOverrides not invoked after content type creation in Drupal 10.3.0+ Active

for me also patch from #99 broken after 3.6 upgrade

This https://git.drupalcode.org/project/drupal/-/commit/9bb46296cee3aa33a9750... is the commit on Mar 27, 2024 which causing our test to failure.

I ran the bisect between tags 10.2.7 and 10.3.1 by running below command
git bisect start
git bisect good tags/10.2.7
git bisect bad tags/10.3.1

then the commit which I get is setting the drupal core to 11.0-dev which leads to break testing.

will git bisect show the code difference between these two versions?

Hi are we fixing this issue in this module or are we waiting for https://www.drupal.org/project/drupal/issues/2940605 🐛 Can only intentionally re-render an entity with references 20 times Needs work to be fixed from core then?

Patch #21 working fine for me with drupal 10.2.7

Thanks for reply andy.
Yes for our use case it might be needed as we are creating some predefined block based to the base theme condition in hook_theme_installed() hook.

We are also using this function in our custom module. But after deprecation there are no replacements suggested here.
So Is there any alternate workaround to achieve this?

I see upstream issue is closed. So is that something missing from Drupal side or we need to see any workaround plugin

Any update on this issue?
Will this be included in core?

ok

nitesh624 → created an issue.

what is the proper method to get the reference entity object in node template. so that when there is no data in field reference then I will get null instead of node object.

I guess the problem is in the template itself

1. I have added a taxonomy reference field (field_taxonomy_ref) in article content type.
2. Then in node--article.html.twig file I print {{ dump(node.field_taxonomy_ref.entity) }}, Which returns taxonomy entity object when there is data in this field but when this field is left empty then I am getting node object.

thanks cilefen. Do you have link to documentation around this twig filter stuff?

nitesh624 → created an issue.

Did any faced this issue?

nitesh624 → created an issue.

ok thanks

Can you some example how to achieve this

So i need to do this via hook_preprocess_template right?

nitesh624 → created an issue.

so will there be any issue, if any sites does not provide this permission-policy header?

ok thanks

shouldn't this issue to be fixed from core instead of using contrib module?

but our site does not have any track for used for advertisement.
By default chrome://settings/adPrivacy/interests settings is check and if I unchecked it the console error gone