Problem/Motivation
Existing Custom Function test is failing
Steps to reproduce
I have written a custom functional test earlier to cover some basic scenario provided by this module
Here is my code snippet
$user = $this->drupalCreateUser();
$user->addRole('administrator');
$user->save();
$this->drupalLogin($user);
// Test if user is able to see section-library listing page.
$this->drupalGet('/admin/content/section-library');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains('No templates are available.');
// Goto the the layout page.
$this->drupalGet("node/{$this->lbPage->id()}/layout");
$assert_session = $this->assertSession();
$assert_session->statusCodeEquals(200);
$page = $this->getSession()->getPage();
// Make sure that user is able to see Import from Library link.
$assert_session->linkExists('Import from library');
// Add a section on the layout page.
$this->clickLink('Add section');
$this->clickLink('One column');
$page->fillField('layout_settings[label]', 'My Section');
$page->pressButton('Add section');
$expected_labels = [
'My Section',
'Content region in My Section',
'Section 2',
'Content region in Section 2',
];
$labels = [];
foreach ($page->findAll('css', '[role="group"]') as $element) {
$labels[] = $element->getAttribute('aria-label');
}
// Make sure that the section is available on the page.
$this->assertSame($expected_labels, $labels);
// Make sure that user is able to see Add to Library link.
$assert_session->linkExists('Add section to library');
// Add that section to library.
$this->clickLink('Add section to library');
$page->fillField('label[0][value]', 'Section library label');
$page->pressButton('Add section');
$this->clickLink('Import from library');
$this->assertSession()->elementTextContains('xpath', '//ul[@class="section-library-links"]//li//a//span[@class="section-library-link-label"]//text()', 'Section library label');
// Test that the added section is available on the library listing page.
$this->drupalGet('/admin/content/section-library');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->elementTextContains('xpath', '//div[@class="views-element-container"]//table//td[@class="views-field views-field-label"]//text()', 'Section library label');
// Logout the user.
$this->drupalLogout();
}
But now my test is failing at below step of above test
$this->clickLink('Import from library');
$this->assertSession()->elementTextContains('xpath', '//ul[@class="section-library-links"]//li//a//span[@class="section-library-link-label"]//text()', 'Section library label');
I am getting below error
The website encountered an unexpected error. Try again later.
Error: Call to a member function getSetting() on null in Drupal\section_library\Controller\ChooseSectionFromLibraryController->getSectionLinks() (line 196 of modules/contrib/section_library/src/Controller/ChooseSectionFromLibraryController.php).
Proposed resolution
Locally I update below line in
section_library/src/Controller/ChooseSectionFromLibraryController.php file
if ($templateDisplay && $templateDisplay->getRenderer('image')) {
$image_style = $templateDisplay->getRenderer('image')->getSetting('image_style');
}
which is working
Earlier it was
if ($templateDisplay && $templateDisplay->getRenderer('image')->getSetting('image_style')) {
$image_style = $templateDisplay->getRenderer('image')->getSetting('image_style');
}
Which is causing the issue.
Remaining tasks
User interface changes
API changes
Data model changes