- Issue created by @ananthakrishnan.kr
- First commit to issue fork.
- Merge request !37Issue-3456654: Addressing patch not applying issue on 10.3.x → (Open) created by Unnamed author
- last update
6 months ago 32 pass - Status changed to Needs review
6 months ago 11:36am 24 June 2024 - 🇮🇳India abhiyanshu
@bharath-kondeti,
Have you checked if the patch is working correctly?
When I apply the patch manually by placing it in the root directory of the module and runninggit apply -v 2869592-disabled-update-module-63.patch
, it throws an error regarding a missing file or directory. The same patch may also encounter issues when applied via Composer. - 🇺🇸United States justcaldwell Austin, Texas
Even after applying the patch from the MR, composer kept using the outdated version of the patch from ✨ Disabled update module shouldn't produce a status report warning Needs work .
- Applying patches for drupal/core https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch (2869592 - Disabled update module shouldn't produce a status report warning)
This has previously been an issue for others but isn't consistent as described 🐛 Update patch that no longer applies Needs review in 🐛 Update patch that no longer applies Needs review .
If you don't have Update disabled anywhere (or don't care whether the message is a Warning rather than just Info), you can ignore the patch entirely by updating your root composer.json:
extra: { ... "patches-ignore": { "drupal/lightning_core": { "drupal/core": { "2869592 - Disabled update module shouldn't produce a status report warning": "https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch" } } }
- 🇮🇳India ananthakrishnan.kr
I am also getting the same error again after applying the patch from the MR.
- 🇧🇷Brazil carolpettirossi Campinas - SP
It would be great if we could get a new module version with the MR approved/merged
- 🇺🇸United States maskedjellybean Portland, OR
After applying the patch from the MR and adding the patches-ignore from #6, try deleting /vendor and /docroot/modules/contrib/lightning_core and then running composer install.
- 🇺🇸United States clayfreeman Paragould, AR
Wouldn't it be much better to simply remove this patch and allow downstream consumers to decide whether they want it or not? For our use case, this patch doesn't really matter and only causes maintenance headaches.
- 🇺🇸United States clayfreeman Paragould, AR
I should also note, this can be done entirely without a patch now with #309040: Add hook_requirements_alter() → .
- 🇮🇳India nitesh624 Ranchi, India
yes agreed with #10. this patch should be optional
- 🇨🇦Canada robbdavis
Thanks for #6! patches-ignore in composer.json sorted it out!