Wrong return type in Drupal\Core\Entity\Plugin\DataType\ConfigEntityAdapter::getConfigTypedData

Created on 31 May 2019, over 5 years ago

Updated 19 June 2024, 6 months ago

Problem/Motivation

Drupal\Core\Entity\Plugin\DataType\ConfigEntityAdapter::getConfigTypedData has wrong return type in docblock:
TypedConfigManager::createFromNameAndData() returns a TraversableTypedDataInterface not ComplexDataInterface. Confusing IDE's and contributers alike.

Steps to reproduce

N/A

Proposed resolution

Fix TypedConfigManagerInterface documentation

Remaining tasks

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Entity →

Last updated about 16 hours ago

Maintained by
🇬🇧United Kingdom @catch
🇨🇭Switzerland @berdir
🇩🇪Germany @hchonov

Created by

🇳🇱Netherlands karel010

Live updates comments and jobs are added and updated live.

Configuration system

Bug Smash Initiative

Incomplete comments

Merge Requests

!8407 Wrong return type in Drupal\Core\Entity\Plugin\DataType\ConfigEntityAdapter::getConfigTypedData
Open
🇦🇺Australia acbramley
updated 7 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

First commit to issue fork.
Status changed to Needs review 7 months ago4:03am 14 June 2024
Comment 7 months ago →
🇦🇺Australia acbramley
Created an MR based on #11 (at least how I interpret it).

By the sounds of it, it's createFromNameAndData that needs to change.
Merge request !8407Issue #3058414: Fix createFromNameAndData → (Open) created by acbramley
Comment 7 months ago →
🇦🇺Australia acbramley
Pipeline finished with Success
7 months ago
Total: 547s
#198525
Comment 6 months ago →
🇺🇸United States smustgrave
So when I add ComplexDataInterface as the return type in TypedConfigManager.php IDE throws a warning that it needs to be TypedDataInterface
Status changed to Needs work 6 months ago6:21pm 19 June 2024
Comment 6 months ago →
🇺🇸United States smustgrave
Checked again shouldn't it be TypedDataInterface

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024