Contrib.social

Add $isSyncing as an argument to config entity hooks?

Open on Drupal.org →
Created on 11 April 2014, about 11 years ago
Updated 15 March 2025, about 1 month ago

Coming from #2124535: Prevent secondary configuration creates and deletes from breaking the ConfigImporter → , though I think this was actually introduced in another issue originally.

That patch added a lot of lines like this:

+++ b/core/modules/image/image.module
@@ -387,6 +387,10 @@ function image_entity_presave(EntityInterface $entity) {
+  if ($field->isSyncing()) {
+    return;
+  }

This requires module developers to a) know about this method, b) know they're supposed to check it, c) know exactly when/why to do so. This would be a lot easier to communicate if it were an argument in the hook itself, because then we could just document it.

Thoughts?

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

configuration entity system

Created by

🇨🇦Canada webchick Vancouver 🇨🇦

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 1 month ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

  • Comment about 1 month ago →
    🇨🇭Switzerland berdir Switzerland

    We have \Drupal\Core\Entity\SynchronizableInterface since 2018 which is exactly this.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024