Prevent uuidKey from being overridden in Configuration entities

Is this still relevant? Can we get a failing test from the test changes above?

Re-roll patch and added tests, please review.

Fixed Issue #23 Please review

The last submitted patch, 24: 2604450-test-24.patch, failed testing. View results →

Seems reroll showed the issue does exist. Ran the tests for 11.x and all green there.

Thanks for breathing life into this long stale issue!
Couple of minor observations/questions but this looks close.

I also think there's a risk of disruption here, so moving this to 11.x so it will be 10.2 only (next minor release).

Can we also get a change notice and release notes snippet?

Thanks!

1. +++ b/core/modules/config/tests/config_test/src/Entity/ConfigTest.php
   @@ -26,7 +26,8 @@
   + *     "status" = "status",
   + *     "uuid" = "fake_key_to_ensure_this_does_not_work"
   

   Are we using this in any of the tests?

2. +++ b/core/tests/Drupal/Tests/Core/Config/Entity/ConfigEntityStorageTest.php
   @@ -36,6 +36,13 @@
   +  protected $entityType;
   
   @@ -78,6 +85,12 @@ class ConfigEntityStorageTest extends UnitTestCase {
   +  protected $memoryCache;
   

   I don't think we need class properties if we're only using them in one test case, let's just make these inline variables

Patch added against #27 Point 1. and still Pending 2 point so need work.