🇬🇷Greece @TheodorosPloumis

I have no issues with the PR number 97. Thanks!

I was working with the patch from 95.

I found an issue with this feature which may be related to the main module.

When I enable the new module graphql_compose_linkattributes it seems that I cannot override later the Link class with another custom module. Only when I disable the the module graphql_compose_linkattributes I can override it.

How to reproduce this? Enable the graphql_compose_linkattributes module from this patch and then create another module that has similar functionality to this. When you enable it the new fields are not attached to the LinkType (although the new GraphQL type is available on Docs).

We may need to investigate here, also, if methods hook_graphql_compose_graphql_type_alter() and hook_graphql_compose_field_type_alter() allows for multiple and correct inheritance.

theodorosploumis → made their first commit to this issue’s fork.

That's correct, thanks.

theodorosploumis → made their first commit to this issue’s fork.

There is no such built-in feature on graphql_compose currently.
You can achieve this in different ways.

1) Create a GraphQL compose views and get there the Nodes filtered bty taxonomy term tid. See https://drupal-graphql-compose.github.io/documentation/#/features/views
2) Add a custom Field on the Node Union query (programmatically) to get the Nodes of a taxonomy. See https://drupal-graphql-compose.github.io/documentation/#/extending/custo...
3) Use module https://www.drupal.org/project/viewfield → to create a Views field on the taxonomy and then get the Nodes there. See https://drupal-graphql-compose.github.io/documentation/#/contrib/viewfield.

Notice that this module extends the graphql module. The code you describe refers to the graphql module and not this one.

theodorosploumis → made their first commit to this issue’s fork.

Here are the modules we are working on. The most interesting are the debug, file_upload, mutations, logout, register, reset_password. The other ones are are self explained. They simply entity related with some minor customizations and extensions on fields.

- graphql_compose_activities
- graphql_compose_debug
- graphql_compose_files
- graphql_compose_file_upload
- graphql_compose_flaggings
- graphql_compose_logout
- graphql_compose_messages
- graphql_compose_mutations
- graphql_compose_posts
- graphql_compose_private_messages
- graphql_compose_profiles
- graphql_compose_register
- graphql_compose_reset_password

I do have a ready mutations module (with exactly that name) but I need some time to create the PR.
In fact, I do have many other submodules I created based on the graphql_compose module but need some work to make them at least ready for review.

theodorosploumis → created an issue.

TheodorosPloumis → created an issue.

TheodorosPloumis → created an issue.

TheodorosPloumis → created an issue.

We also have a similar issue on a SOLR 7.x server with about 100k Search API Items.
Looking for solutions too.

One option that seems to work better is to use the "Solr Suggester" (but this requires SOLR).

TheodorosPloumis → created an issue.

We are using the https://www.drupal.org/project/file_entity → module to get nested Files indexed on search_api.
This is used for files inside Drupal of course.

TheodorosPloumis → created an issue.

@hydra This is what I did. Just wanted a static patch because the one from the PR may not apply at some time.

Attaching a static patch from the PR.

I think that mini pager is the better option here. The main reasons for this decision are:

1) Consistency, as mentioned on the issue title.
2) Performance. Mini pager is less heavy than the full pager.
3) Usability. Media are usually attached to Nodes. So navigating to the first or last item is not something really important.

TheodorosPloumis → made their first commit to this issue’s fork.

Add Tocbot 9.x+ module

Patch from #5 works for me.

TheodorosPloumis → made their first commit to this issue’s fork.

Add https://pagespeed.web.dev in place of the old https://developers.google.com/pagespeed/ link.

Minor typo fixes

Add example of how to attach library of an SDC component in a twig.

TheodorosPloumis → created an issue.

Had the same issue when installed the taxonomy_machine_name → module.

TheodorosPloumis → made their first commit to this issue’s fork.

Add an adnaved example of using Dialog options in twig.

Duplicate of https://www.drupal.org/node/3370060 → .

Add module  https://www.drupal.org/project/sdc_styleguide →

Rate your excitement about SDC in core: 1 ... 10 | N/A

10

Rate your excitement about potential contrib extending SDC: 1 ... 10 | N/A

10

Rate our documentation: 1 ... 10 | N/A

9

Did you 1️⃣ refactor existing template into a component, or did you 2️⃣ write a component from scratch? 1 | 2

1 and 2

Rate the helpfulness of error messages encountered: 1 ... 10 | N/A

10

Have you tried the Storybook integration? Yes | No

Yes

Any thoughts you would like to share? The sky is the limit

Nice to have features:
- Add new sc_server render pages for each Component like the "*.component.yml, twig, js, css" raw source so we can use them in Storybook directly
- More documentation about overriding, extending, defining sdc Components
- A drush command to generate sdc Component (in its folder) from existing Twig (Drupal) template
- An online sdc Components repository where we can share and reuse our sdc Components like https://bit.dev
- A simpler way to ovverride an sdc Component without the need of adding the same props on the *component.yml file
- Add "Open on IDE" contextual link on each sdc Component (using the ComponentMatadata path) on the sdc render or the Twig debug HTML comments
- Create an official package.json demo that generates CSS/JS inside Components folders
- Extend the default sdc schema to allow (recognize) the Drupal specific Prop "Attribute":

attributes:
      type: Drupal\Core\Template\Attribute

Add "Add a remote schema on IDE" section on footer.

This now applies only for the 2.x-dev version. Changed the Version accordingly.

Actually, I see that the generator is using the Chi-teck/drupal-code-generator so the tests should look like here https://github.com/Chi-teck/drupal-code-generator/tree/3.x/tests.

Drush itself has a Test Suite named Unish.

Most of the Drush tests here are based on Unish.

Some non-PHP tools and processes are mentioned here on this post Testing The CLI The Way People Use It, Smashing Magazine, 2022.

This is a good suggestion.

But if you want to disallow the component using the postcss files add them in a subfolder inside the component and manage the compiling accordingly. Example:

/my-component/
- my-component.css
- my-component.twig
- my-component.yml
/pcss
- my-postcss-component.css

TheodorosPloumis → created an issue.

@obriat If we run "composer install" and we remove the module from the filesystem then the command "drush cim" may break (fatal error from Drupal). The best commands order is like this:

git pull ...
drush updb --no-cache-clear
drush cache:rebuild
composer install ...
drush config:import
drush updb
drush cache:rebuild

"composer install" command should run after the "drush updb" because we may need to run hook_update_N to remove a module etc.

I would like to become a maintainer for this module. @keenegan can you please add me? Thanks.

The patch for MR https://git.drupalcode.org/project/human_decimal/-/merge_requests/1.

TheodorosPloumis → created an issue.

TheodorosPloumis → created an issue.

I am waiting for this also. We have a 10.x website using this patch and works fine.
Thanks.

We solved a similar issue for an existing project (we had the issue due to updates) like this:

1) We require a fixed version of the drupal/opigno_lms package (eg "3.0.9")
2) We removed all the first level dependencies on our composer.json that already exist on the opigno_lms composer.json
3) We edited our composer.json so the version of "mozilla/pdf.js": "v2.4.456" can be found correctly on our composer.

{
    "type": "package",
    "package": {
        "name": "mozilla/pdf.js",
        "version": "v2.4.456",
        "type": "drupal-library",
        "dist": {
            "url": "https://github.com/mozilla/pdf.js/releases/download/v2.4.456/pdfjs-2.4.456-es5-dist.zip",
            "type": "zip"
        }
    }
},

It may be a core issue since I get this for several projects that use the same code on hook_install(). The "AUTHENTICATED" role simply does not exist for some reason dut to wrong order of execution.

See:

- https://www.drupal.org/project/drupal/issues/2906107 🐛 hook_install() is invoked before the module's default config is installed during config import Needs work
- https://www.drupal.org/project/drupal/issues/793660 🐛 Check for failure of hook_install Needs work

Adding a plain patch from the first merge request.

TheodorosPloumis → created an issue.

TheodorosPloumis → made their first commit to this issue’s fork.

We have the some problem on a migration from a 7.x multilingual Drupal (using module entity_translation → ) where the sorting of the revisions cause new Nodes on the 10.x Drupal to have a wrong "Original language" (source).

The sorting was like this (for an "en/de/nl/fr" language setup):

vid=1, language=de
vid=1, language=en
vid=1, language=fr
vid=1, language=nl

The solution was to add an extra sortBy the "created" column because the source translation revision is always created first. After the patch the sorting was:

vid=1, language=en
vid=1, language=de
vid=1, language=fr
vid=1, language=nl

Even with this patch we need to add specific Tests.

TheodorosPloumis → made their first commit to this issue’s fork.