Support for Link Attributes

I applied the patch and tested on a web site and is working.

Drupal Version 10.2.6
PHP 8.2.21

+1 on this submodule

Happy to bring this into main module rather than a sub module.

Also looks like changes have been made on the 2.2.x branch and not on the issue branch. I'll do some force pushes to move this around.

almunnings → closed merge request !91

We also did something like this but with support for custom attributes. Instead of just only adding the default attributes for the module. The custom attributes are 'style' and 'type'. But this can be everyting since we loop over the definitions from the \Drupal\link_attributes\LinkAttributesManager

+1

Heyya
I've combined the feedback.

Are you able to test PR 97 please.

I found an issue with this feature which may be related to the main module.

When I enable the new module graphql_compose_linkattributes it seems that I cannot override later the Link class with another custom module. Only when I disable the the module graphql_compose_linkattributes I can override it.

How to reproduce this? Enable the graphql_compose_linkattributes module from this patch and then create another module that has similar functionality to this. When you enable it the new fields are not attached to the LinkType (although the new GraphQL type is available on Docs).

We may need to investigate here, also, if methods hook_graphql_compose_graphql_type_alter() and hook_graphql_compose_field_type_alter() allows for multiple and correct inheritance.

On or 95 or 97?
I’m working with 97

I was working with the patch from 95.

Grab 97 please. 95 I’m not gonna merge. If same issues happy to move fwd on your feedback

I have no issues with the PR number 97. Thanks!

I don't have menu_link_attributes module enabled but do have link_attributes. Problem i'm having is the schema type in LinkAttributesType.php is set to nonNull. So my graphql queries fail on menus with this. Setting it to getNullableType fixes it for me.

Works great with my commit to allow null.