🇺🇸United States @jmolivas

volkswagenchick → credited jmolivas → .

thanks for the MR sijumpk
How about providing a textarea field to allow users to override values via UI ?

Based on this other one https://www.drupal.org/project/graphql_compose/issues/3475430 ✨ Add support for webform field Active

I believe we should close this one as well @almunnings

Totally agree @almunnings I am currently testing the module and works fine, some features are missing but that it's the other module responsibilities

Thanks for the reply

nicxvan → credited jmolivas → .

Agree 2nd make sense but not sure how much overhead will add

We may need to add a button to trigger the open functionality, not sure but what make sense to me is adding a toolbar https://monosnap.com/file/EQq0k5YRxHwbuJkqjhfBtvaYZNtRgC

We already adding some extra options when using content moderation module
https://monosnap.com/file/9q37Z1zyLQW91aNklW7GqWNFToZNXw

@theodorosploumis Are any of those modules publicly published?

I am interested on the mutations module(s) my goal is to build a PoC adding https://puckeditor.com/ to the https://drupal-decoupled.octahedroid.com/ project?

Hi @sarwan_verma do you have any plans to keep working on this?

Thanks for the MR @klaasvw taking a look to this

Thanks for the MR @klaasvw taking a look to this

Yup make sense @apmsooner thanks for confirming

jmolivas → created an issue.

jmolivas → created an issue.

apmsooner → credited jmolivas → .

Make sense and like the approach, thanks for the suggestion

Thanks for the MR @aaron.ferris since this chance was 10.2+ this means we may going to break lower Drupal versions prior to that? what do you suggest could be the ideal path to avoid breaking previous versions?

Can we also make sure we use dependency injection instead of calling \Drupal static class?

- phpstan report

 ------ ---------------------------------------------------------------------- 
  Line   src/Form/SettingsForm.php                                             
 ------ ---------------------------------------------------------------------- 
  197    \Drupal calls should be avoided in classes, use dependency injection instead                                                               

Thanks for the MR @sarwan_verma, the code change introduces new issues could you have them fixed in order to merge the code

- phpcs

--------------------------------------------------------------------------------
FOUND 6 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
 197 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters
     |         |     (Drupal.Files.LineLength.TooLong)
 197 | ERROR   | [x] Comments may not appear after statements
     |         |     (Drupal.Commenting.PostStatementComment.Found)
 197 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
     |         |     question marks, colons, or closing parentheses
     |         |     (Drupal.Commenting.InlineComment.InvalidEndChar)
 200 | WARNING | [ ] Line exceeds 80 characters; contains 122 characters
     |         |     (Drupal.Files.LineLength.TooLong)
 200 | ERROR   | [x] Comments may not appear after statements
     |         |     (Drupal.Commenting.PostStatementComment.Found)
 200 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks,
     |         |     question marks, colons, or closing parentheses
     |         |     (Drupal.Commenting.InlineComment.InvalidEndChar)
 203 | ERROR   | [x] Whitespace found at end of line
     |         |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
 206 | ERROR   | [x] Whitespace found at end of line
     |         |     (Squiz.WhiteSpace.SuperfluousWhitespace.EndLine)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 149ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE                                                            ERRORS  WARNINGS
--------------------------------------------------------------------------------
.../decoupled_preview_iframe-3472794/src/Form/SettingsForm.php  6       2
--------------------------------------------------------------------------------
A TOTAL OF 6 ERRORS AND 2 WARNINGS WERE FOUND IN 4 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 6 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
----------------------------------------------------------------------
    SOURCE                                                       COUNT
----------------------------------------------------------------------
[x] Drupal.Commenting.InlineComment.InvalidEndChar               2
[x] Drupal.Commenting.PostStatementComment.Found                 2
[ ] Drupal.Files.LineLength.TooLong                              2
[x] Squiz.WhiteSpace.SuperfluousWhitespace.EndLine               2
----------------------------------------------------------------------
A TOTAL OF 8 SNIFF VIOLATIONS WERE FOUND IN 4 SOURCES
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SOURCES AUTOMATICALLY (6 VIOLATIONS IN TOTAL)
----------------------------------------------------------------------

jmolivas → created an issue.

jmolivas → created an issue. See original summary → .

I took care and send a MR ;) thanks for reporting it @radheymkuma

jmolivas → made their first commit to this issue’s fork.

Hi @radheymkumar are you planning to send a MR ?

nice catch @brianperry and thanks for the MR

What other submodules and which features are you working on theodorosploumis?

jmolivas → created an issue.

I kinda like the idea of mutations, this could be a separated submodule graphql_compose_mutations we definitely need to make sure we take care in a careful way to avoid the data producer monster.

+1 on this submodule

This feature make sense to me since could provide expected capabilities if migrating from v3.x

jmolivas → created an issue.

included on 1.0.6

included on 1.0.6

jmolivas → created an issue.

jmolivas → created an issue.

Nice catch @drupalninja99 will test and have it merged

Awesome thanks @christefano

Just for the record we took a lot of inspiration from the storyblok UX for this project

jmolivas → created an issue.

jmolivas → created an issue.

jmolivas → created an issue.

jmolivas → created an issue.

jmolivas → created an issue.

jmolivas → created an issue.

jmolivas → created an issue.

jmolivas → created an issue.

jmolivas → created an issue.

jmolivas → created an issue.

Available on 1.0.2

jmolivas → created an issue.

Available on 1.0.6

jmolivas → created an issue.