Account created on 21 April 2022, over 2 years ago
  • Backend Developer at iOΒ 
#

Merge Requests

More

Recent comments

πŸ‡§πŸ‡ͺBelgium cedricl

Looks good, tested it and no errors occured anymore

πŸ‡§πŸ‡ͺBelgium cedricl

Changes in the fork, should be reviewed

πŸ‡§πŸ‡ͺBelgium cedricl

This is working for me. Thanks for the update

πŸ‡§πŸ‡ͺBelgium cedricl

We also did something like this but with support for custom attributes. Instead of just only adding the default attributes for the module. The custom attributes are 'style' and 'type'. But this can be everyting since we loop over the definitions from the \Drupal\link_attributes\LinkAttributesManager

πŸ‡§πŸ‡ͺBelgium cedricl

Turned out te be some obscure (internal) module we had enabled that was changing how the breadcrumbs work. Disabled it and all worked. Closing the issue.

πŸ‡§πŸ‡ͺBelgium cedricl

It seems like it only returns breadcrumbs if the node is in my a menu, but i always want a breadcrumb not only when it's in a menu. I think it is core related, will look into it. And give an update if I find it.

πŸ‡§πŸ‡ͺBelgium cedricl

Also noticed this issue after updating form 2.1.3 to 2.1.4. I downgraded for now, but might be a good thing to look at changes made from 2.1.3 to 2.1.4.

πŸ‡§πŸ‡ͺBelgium cedricl

Fix a type issue in previous patch

πŸ‡§πŸ‡ͺBelgium cedricl

Updated patch to not make entity type behaviors required in graphQL

πŸ‡§πŸ‡ͺBelgium cedricl

Tested the MR and seems to work.

πŸ‡§πŸ‡ͺBelgium cedricl

Added an empty route. This fixed the issue. Changes are in the fork.

πŸ‡§πŸ‡ͺBelgium cedricl

CedricL β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡ͺBelgium cedricl

hi almunnings,

I'm not really a fan of the tokens method since, i like my data spread in seperate query instead of everything in the pageInfo, but this indeed covers most use cases for users. I'll stick to using the edges method i found for now. If i find the time I will update the module so we don't have to use a UUID for a single query. Can be put on hold for now

πŸ‡§πŸ‡ͺBelgium cedricl

I tested patch https://www.drupal.org/files/issues/2023-10-16/2422737-37.patch β†’ from https://www.drupal.org/project/drupal/issues/2422737 πŸ“Œ Tabledrag event after dragging elements Needs work and for me this fixes the issue.

πŸ‡§πŸ‡ͺBelgium cedricl

Added a video for a clearer view of the issue

πŸ‡§πŸ‡ͺBelgium cedricl

Ticket should be reopened. The drag and drop feature for paragraphs still seems to not work. My bad for only reading the title. The auto reload works on changing selects and textareas, so this part is done. But when draging and dropping paragraph the preview doesn't auto reload. And Even when I press the 'preview' button manually it doesn't update. But after updating a random input field it reloads, and also shows the order changes of the paragraphs.

πŸ‡§πŸ‡ͺBelgium cedricl

CedricL β†’ created an issue.

πŸ‡§πŸ‡ͺBelgium cedricl

The patch file fixed the issue. Thanks for the fast responses.

πŸ‡§πŸ‡ͺBelgium cedricl

Updated patch to keep in line with update graphql compose module.

πŸ‡§πŸ‡ͺBelgium cedricl

Added it as a seperate module, since not all sites have multiple languages and therefor don't need this field. The availableLanguages field has a language and url field, but can be extended if needed.

πŸ‡§πŸ‡ͺBelgium cedricl

Tested the MR, seems to work. Could this be merged?

πŸ‡§πŸ‡ͺBelgium cedricl

Tested your last changes, can be merged

πŸ‡§πŸ‡ͺBelgium cedricl

When you have a node and paragraph with the same name, it only adds the entite type behaviors field to the content type in the graphql schema.

With patch v3, it gets added to both the paragraph and the content type with the same name.

πŸ‡§πŸ‡ͺBelgium cedricl

I provided a patch so you don't have to put things in the settings file like this $config['graphql_compose.settings']['field_config']['paragraph']['YOUR_PARAGRAPH_TYPE']['FIELD_YOUR_FIELD_NAME']['required'] = FALSE;
But now you can do it the schema configurer, i've added a checkbox required which by default is set the same as the settings of your field. But you can override it and make that field not required for the schema in GraphQL.

When saving it, the required value gets added to the config.

Not sure if this breaks anything else, but for our use case i haven't seen it breaking something. Should be tested and reviewed

πŸ‡§πŸ‡ͺBelgium cedricl

We did this, but made it hardcoded only for the fields we needed, you can take a look in our module for inspiration.

πŸ‡§πŸ‡ͺBelgium cedricl

It looks like the changes that happened in your merge request are removed from 2.1, in a later commit. I added a patch to re-include these changes, so the preview with paragraphs works again.

πŸ‡§πŸ‡ͺBelgium cedricl

Code works as intented. Can be merged.

Thanks Almunnings!

πŸ‡§πŸ‡ͺBelgium cedricl

This seems to be related.
https://www.drupal.org/project/decoupled_preview/issues/3398030 πŸ› Issue With Paragraph Entity Active

πŸ‡§πŸ‡ͺBelgium cedricl

The translations are coming through for items, but the field 'name' isn't being translated. I added the translation for the title of the menu here.
/en/admin/structure/menu/manage/MENU_ID/translate/fr/edit. But when querying the menu in french it still gives the label in the original menu language (Dutch) but the items are in french as should be.

Extra visual info: https://imgur.com/a/RCY8rGp

Ticket should be re-opened.

πŸ‡§πŸ‡ͺBelgium cedricl

Turned out my metatag defaults config files got removed from my site. No clue why this happened, but after adding this the issue was fixed. Ticket can be closed

πŸ‡§πŸ‡ͺBelgium cedricl

Does exactly what I wanted. Thanks for the help @almunnings

πŸ‡§πŸ‡ͺBelgium cedricl

Added schema extension for behaviors in nodes.

πŸ‡§πŸ‡ͺBelgium cedricl

CedricL β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡ͺBelgium cedricl

#3 does the trick. Thanks for the help!

πŸ‡§πŸ‡ͺBelgium cedricl

For drupal core 9.5.x i'm getting
Cannot apply patch https://www.drupal.org/project/drupal/issues/3101671#comment-14976504 (https://www.drupal.org/files/issues/2023-03-21/3101671-21-against-deletable-9.5.x.patch)!
Any fixes for this issue. I also applied the patches from #22

πŸ‡§πŸ‡ͺBelgium cedricl

Fixed issues for the keycloak groups. Some keys in the config file changed names, so did the config file itself. There are still others that need to be changed. But keycloak group mapping is working with this patch.

πŸ‡§πŸ‡ͺBelgium cedricl

Turned out to be a keycloak configuration issue from my side.

πŸ‡§πŸ‡ͺBelgium cedricl

Fixed undefined classes for 3.X-dev

Production build 0.71.5 2024