- Issue created by @dieterholvoet
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
Ah interesting, This is likely because the grabbers are not being targeted by the update logic.
I wonder if we need to figure out a special case here or expand the logic for the selector. I'll try to look at this tonight.
- π§πͺBelgium dieterholvoet Brussels
I checked and every row has a select element containing the paragraph delta. Which made me discover that live reload isn't triggered when changing any select element in the node edit form, so changing the issue title.
- Assigned to dieterholvoet
- π§πͺBelgium dieterholvoet Brussels
Also not triggered in textareas, I'll fix that here as well.
- π§πͺBelgium dieterholvoet Brussels
It currently doesn't seem to be possible to react to tabledrag changes, not even when listening to the select elements carrying the deltas: π Tabledrag event after dragging elements Needs work . I'll create a separate issue to track that problem so we can focus on getting standard selects/textareas to work here.
- Merge request !55Issue #3391528: Auto reload is not triggered when changing selects or textareas β (Merged) created by dieterholvoet
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 1:17pm 13 October 2023 - πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
Thanks for the MR @DieterHolvoet I hope to have time to review it today.
When you say, that the preview should update on textarea. Should it be constantly changing when you are typing inside a CKEditor5? Because with the current committed code reload only happens when CKEditor loses focus.
When using select, it updates immediately when selecting a different option, that part works fine. Since I'm not sure about how CKEditor5 interaction should update the preview, I'm leaving it as needs review for now.
- π§πͺBelgium dieterholvoet Brussels
When you say, that the preview should update on textarea. Should it be constantly changing when you are typing inside a CKEditor5? Because with the current committed code reload only happens when CKEditor loses focus.
No, it's still only when losing focus. And not only CKEditor, but any text area.
Thanks for the answer.
Noticed that nested editor elements didn't trigger auto-reload when you clicked outside the editor. Only when you click inside it. For example on Full HTML, if you add a table, fill in the content, and then click anywhere but the editor the preview doesn't update.
Added so it also listens to
OnBlur
for.ck-editor__nested-editable
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
I'll review this tonight!
- π§πͺBelgium cedricl
Tested the MR, seems to work. Could this be merged?
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
Good news! I'll be traveling to Midcamp tomorrow. I'll be meeting with previous contributors of this module and talking up a gameplan for work (leading up to Drupalcon).
I'll put this to top of my list of issues to consider. Stay tuned.
-
cosmicdreams β
committed 6d0a354f on 2.1.x authored by
DieterHolvoet β
Issue #3391528: Auto reload is not triggered when changing selects or...
-
cosmicdreams β
committed 6d0a354f on 2.1.x authored by
DieterHolvoet β
- Status changed to Fixed
8 months ago 4:58pm 20 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- π§πͺBelgium cedricl
Ticket should be reopened. The drag and drop feature for paragraphs still seems to not work. My bad for only reading the title. The auto reload works on changing selects and textareas, so this part is done. But when draging and dropping paragraph the preview doesn't auto reload. And Even when I press the 'preview' button manually it doesn't update. But after updating a random input field it reloads, and also shows the order changes of the paragraphs.
- π§πͺBelgium dieterholvoet Brussels
@CedricL there's a child issue for that: π Auto reload is not triggered when changing tabledrag elements Active .